New issue
Advanced search Search tips

Issue 831722 link

Starred by 2 users
Status: Assigned
Owner:
braveyao@chromium.org
Cc:
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use DesktopStreamsRegistry for both desktopCapture and tabCapture to register streams

Project Member Reported by braveyao@chromium.org, Apr 11 2018 
For easily accessing the content of the current tab and share/record together with mic or camera data. 

Proposal: https://docs.google.com/document/d/1YWFmFJaN-bbAxh01JP5qczERW9vda62vLInO32WvCM8/edit?ts=5ac7ebd8#heading=h.uojtbfpulw5q
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/560b85bad747612af43a72b7990309199ebfedc0

commit 560b85bad747612af43a72b7990309199ebfedc0
Author: Weiyong Yao <braveyao@chromium.org>
Date: Fri Jul 20 22:12:05 2018

[tabCapture] use randomly generated device ID

use a "randomly generated device ID" scheme, like that employed by
the desktop capture API.

Bug: 163100, 831722
Change-Id: Idcf46dad59bc822c2a5115418420e22775269068
Reviewed-on: https://chromium-review.googlesource.com/1093439
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577009}
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/BUILD.gn
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[delete] https://crrev.com/95a633acffa831c7832df7a61aacc536ba5aafba/chrome/browser/media/webrtc/desktop_streams_registry.cc
[delete] https://crrev.com/95a633acffa831c7832df7a61aacc536ba5aafba/chrome/browser/media/webrtc/desktop_streams_registry.h
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/media/webrtc/media_capture_devices_dispatcher.h
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/chrome/browser/media/webrtc/screen_capture_infobar_delegate_android.cc
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/content/browser/BUILD.gn
[add] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/content/browser/media/capture/desktop_streams_registry_impl.cc
[add] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/content/browser/media/capture/desktop_streams_registry_impl.h
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/content/public/browser/BUILD.gn
[add] https://crrev.com/560b85bad747612af43a72b7990309199ebfedc0/content/public/browser/desktop_streams_registry.h

Comment 2 by braveyao@chromium.org, Jul 24

Summary: Use DesktopStreamsRegistry for both desktopCapture and tabCapture to register streams (was: Add a new method to tabCapture API)
This is also necessary for the proposed tabCapture.getMediaStreamId() method.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93

commit a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93
Author: Weiyong Yao <braveyao@chromium.org>
Date: Tue Aug 07 03:04:54 2018

Add stream type to DesktopStreamsRegistry APIs

As we're going to use DesktopStreamRegistry for both desktopCapture
and tabCapture registry, it's important to let getUserMedia() to be
called with corresponding source type, 'desktop' or 'tab', which will
lead to different UI indicator.
This cl is to add the source type at adding/verifying request to
the registry.

Bug: 831722
Change-Id: If53022ec35c3c3b7993e41149e381b96b3e48877
Reviewed-on: https://chromium-review.googlesource.com/1149192
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581108}
[modify] https://crrev.com/a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
[modify] https://crrev.com/a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[modify] https://crrev.com/a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93/content/browser/media/capture/desktop_streams_registry_impl.cc
[modify] https://crrev.com/a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93/content/browser/media/capture/desktop_streams_registry_impl.h
[modify] https://crrev.com/a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/a01798febbb4b5d7f0bb1f4d1c9515c3218a8a93/content/public/browser/desktop_streams_registry.h

Comment 4 by anatolid@chromium.org, Aug 27

Labels: M-70
Is this finished?

Comment 5 by braveyao@chromium.org, Aug 27

Labels: -M-70 M-71
Not yet. Need more cleanup. Filed issue875492 for extension API processing.
►

Sign in to add a comment