New issue
Advanced search Search tips

Issue 831720 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 810437

Blocking:
issue 812893


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Multiple virtual/modern-media-controls/media/controls/modern layout tests flaky

Project Member Reported by kbr@chromium.org, Apr 11 2018

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/67679

Layout test results:
https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/67679/layout-test-results/results.html

Excerpt:

This is a testharness.js-based test.
FAIL Test that player will jump to the end if less than 10 seconds remaining. assert_not_equals: got disallowed value 57
Harness: the test ran to completion.

Assigning steimel@ from searches through bug database. Landing a suppression for this flaky test, as there are a large number of flakes right now in  Issue 810437  and we have to start addressing the ones known.

 

Comment 1 by kbr@chromium.org, Apr 11 2018

Suppressing these flakes in https://chromium-review.googlesource.com/1007976 .

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20d76e08e5e8da948e05c7ba9cc184ee04159116

commit 20d76e08e5e8da948e05c7ba9cc184ee04159116
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Apr 12 01:21:08 2018

Suppress flakes in doubletap-to-jump-forwards-too-short.html.

Suppressing flakes in the following layout test:

  virtual/modern-media-controls/media/controls/modern/
    doubletap-to-jump-forwards-too-short.html

Tbr: steimel@chromium.org
Bug: 831720
Change-Id: Id8975175c8a0001e433cdcc693b340170a5036c2
Reviewed-on: https://chromium-review.googlesource.com/1007976
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549992}
[modify] https://crrev.com/20d76e08e5e8da948e05c7ba9cc184ee04159116/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by kbr@chromium.org, Apr 12 2018

Labels: -Pri-1 Pri-2
Downgrading to P2 now that the suppressions are in place.

Comment 4 by kbr@chromium.org, Apr 12 2018

Summary: Multiple virtual/modern-media-controls/media/controls/modern layout tests flaky (was: virtual/modern-media-controls/media/controls/modern/doubletap-to-jump-forwards-too-short.html flaky)
Seeing flakes in other layout tests. The one originally reported against was:

virtual/modern-media-controls/media/controls/modern/doubletap-to-jump-forwards-too-short.html
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/67679

Now seeing a flake in:
virtual/modern-media-controls/media/controls/modern/tap-to-hide-controls.html
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/68947

Layout test results:
https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/68947/layout-test-results/results.html

Results:

This is a testharness.js-based test.
FAIL Test that the controls are hidden if they are tapped assert_false: expected false got true
Harness: the test ran to completion.


Marking flaky.

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d03acae8fab434ffc9eb79ff862c1012a680c69f

commit d03acae8fab434ffc9eb79ff862c1012a680c69f
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Apr 12 21:58:33 2018

Suppress flaky layout tests.

  virtual/modern-media-controls/media/controls/modern/
    tap-to-hide-controls.html
  fast/forms/search/search-appearance-basic.html

Tbr: steimel@chromium.org, wangxianzhu@chromium.org
Bug: 831720, 832274
Change-Id: I301a309a7469d4cd54beaddb2c7f7a4727510ecb
Reviewed-on: https://chromium-review.googlesource.com/1011044
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550375}
[modify] https://crrev.com/d03acae8fab434ffc9eb79ff862c1012a680c69f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d03acae8fab434ffc9eb79ff862c1012a680c69f

commit d03acae8fab434ffc9eb79ff862c1012a680c69f
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Apr 12 21:58:33 2018

Suppress flaky layout tests.

  virtual/modern-media-controls/media/controls/modern/
    tap-to-hide-controls.html
  fast/forms/search/search-appearance-basic.html

Tbr: steimel@chromium.org, wangxianzhu@chromium.org
Bug: 831720, 832274
Change-Id: I301a309a7469d4cd54beaddb2c7f7a4727510ecb
Reviewed-on: https://chromium-review.googlesource.com/1011044
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550375}
[modify] https://crrev.com/d03acae8fab434ffc9eb79ff862c1012a680c69f/third_party/WebKit/LayoutTests/TestExpectations

These tests are also flaking on Mac bots:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests


Comment 8 by kbr@chromium.org, May 3 2018

jonross@ can you expand my suppression to Mac too? Sorry I didn't do that in the first place.

Comment 9 by kbr@chromium.org, May 3 2018

Labels: OS-Mac OS-Windows

Comment 10 by kbr@chromium.org, May 11 2018

virtual/video-surface-layer/media/controls/modern/tap-to-hide-controls.html still observed flaky on mac:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/43502

Expanding suppression for this test.

Project Member

Comment 11 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5a218ff691d52844a51aeb0d16d5ca85b8654ea

commit c5a218ff691d52844a51aeb0d16d5ca85b8654ea
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri May 11 01:05:22 2018

Suppress layout test flakes.

Failures on all platforms:
  virtual/video-surface-layer/media/controls/modern/
    tap-to-hide-controls.html

Timeouts:
  fast/events/hr-timestamp/input-events.html

Bug:  810437 , 831720
Change-Id: I538493dc8a815e04effe5090ad432ad79fa477e8
Tbr: steimel@chromium.org
Tbr: skyostil@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1054849
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557747}
[modify] https://crrev.com/c5a218ff691d52844a51aeb0d16d5ca85b8654ea/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 12 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e6e3553d8a878c73765f0987ecf09d07326034

commit a3e6e3553d8a878c73765f0987ecf09d07326034
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 14 08:56:39 2018

Mark virtual/video-surface-layer/media/controls/modern/doubletap-to-jump-forwards-too-short.html flaky.

TBR=steimel@chromium.org
NOTRY=true

Bug: 831720
Change-Id: I4c57a348bc782c74a26b1fd3a8f224b1a29004f0
Reviewed-on: https://chromium-review.googlesource.com/1056909
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558231}
[modify] https://crrev.com/a3e6e3553d8a878c73765f0987ecf09d07326034/third_party/WebKit/LayoutTests/TestExpectations

Comment 13 by kbr@chromium.org, Jun 20 2018

Blocking: -810437

Comment 14 by kbr@chromium.org, Jun 20 2018

Blockedon: 810437

Sign in to add a comment