New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831700 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

libwayland-egl.so.1 absent from some swarming test bots

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 11 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of kmarshall@chromium.org

content_browsertests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29


I'm seeing flaky linking of the libwayland-egl.so.1 on the bots.

Erorr message: "./content_browsertests: error while loading shared libraries: libwayland-egl.so.1: cannot open shared object file: No such file or directory"

Failed run: https://chromium-swarm.appspot.com/task?id=3cce2d56d7386810&refresh=10
Successful retry: https://chromium-swarm.appspot.com/task?id=3cceb32af35b9e10&refresh=10&show_raw=1
 
It looks like the failed run has to do with the failed bot lacking libwayland-egl.so.1 in its system image.
Labels: -Pri-2 OS-Chrome Pri-1 Type-Bug
Owner: hzl@chromium.org

Comment 4 by sky@chromium.org, Apr 11 2018

Owner: sky@chromium.org
Status: star (was: Available)
Possibly related to https://chromium-review.googlesource.com/c/chromium/src/+/1005567 . Will look more deeply.

Comment 5 by sky@chromium.org, Apr 11 2018

Status: Started (was: Star)

Comment 6 by sky@chromium.org, Apr 11 2018

Cc: reve...@chromium.org
Actually, this seems more like a bot issue that it doesn't have wayland, and I think the first failure is before my patch landed. Also, my patch didn't actually change any required libraries. I don't see wayland in the list of packages in build/install-build-deps.sh. Maybe that's the issue? I've no idea why this would suddenly be an issue.
 Issue 831699  has been merged into this issue.
Owner: hzl@chromium.org
Assigning to oncall infra trooper hzl@

Comment 9 by sky@chromium.org, Apr 11 2018

Actually, ChromeOS shouldn't currently depend upon wayland-client. (it likely will soon, but not at this time). Will keep poking.

Comment 10 by hzl@chromium.org, Apr 11 2018

Cc: thomasanderson@chromium.org
Would you please take a look at this issue related to build/install-build-deps.sh?

Comment 11 by sky@chromium.org, Apr 11 2018

Owner: sky@chromium.org
I'll take this.

Comment 12 by sky@chromium.org, Apr 11 2018

I went back a month and ChromeOS had dependencies on this:
//content/test:content_browsertests --[private]-->
//content/test:test_support --[private]-->
//ui/ozone:ozone --[public]-->
//ui/ozone:platform --[private]-->
//ui/ozone/platform/wayland:wayland

This is because of this line: https://chromium.googlesource.com/chromium/src/+/master/ui/ozone/ozone.gni#57
So does anybody own the action item of ensuring that bots actually have Wayland library installed?


hzl: did you find something that indicated that libwayland is supposed to be installed by install-build-deps?

As far as I can tell it's missing from the sysroot image?
Cc: hzl@chromium.org
+hzl re #14
Summary: libwayland-egl.so.1 absent from some swarming test bots (was: Dynamic linking of libwayland-egl.so.1 is flaky)

Comment 17 by sky@chromium.org, Apr 11 2018

https://chromium-review.googlesource.com/c/chromium/src/+/1008420 adds wayland to the install-build-deps. If the bots automatically pick this up, then we should be good. I'm not familiar with the sysroot images.
> As far as I can tell it's missing from the sysroot image?

The library has been in the sysroot images for a while but apparently not on the swarming images.  Those must be regenerated and pushed to all the bots.  +friedman could you update the images once https://chromium-review.googlesource.com/c/chromium/src/+/1008420 lands?

Also I think we should revert the cl that's causing this because linux-chromeos-rel is gray on all my CLs and I can't land anything.

Comment 19 by hzl@chromium.org, Apr 12 2018

re #14, I got that inspiration from #6. 
Cc: friedman@chromium.org
+friedman

Comment 21 by hzl@chromium.org, Apr 12 2018

Including @friedman into the loop, re #18
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd7e237ba9b69855adf60e8141b7dc45c613b6a7

commit dd7e237ba9b69855adf60e8141b7dc45c613b6a7
Author: Scott Violet <sky@chromium.org>
Date: Thu Apr 12 01:11:26 2018

Adds wayland-egl to the list of required libraries

Apparently this has been required for a while now on ChromeOS. It's
not really required on non-ChromeOS, but no doubt it will soon, so
adding to both.

BUG= 831700 
TEST=none

Change-Id: I6f859ff4767582c6c2a7155c995347d1963ceebd
Reviewed-on: https://chromium-review.googlesource.com/1008420
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549987}
[modify] https://crrev.com/dd7e237ba9b69855adf60e8141b7dc45c613b6a7/build/install-build-deps.sh

Cc: jchin...@chromium.org
Kicking image creation now.

Comment 24 by sky@chromium.org, Apr 12 2018

thomasanderson, I'm not sure which patch triggered this failure to start happening. I couldn't find anything that changed recently with regards to new deps on wayland.

Comment 25 by sky@chromium.org, Apr 12 2018

Owner: jchin...@chromium.org
Status: Assigned (was: Started)
Cc: -jchin...@chromium.org jbudorick@chromium.org
The image is ready to be canaried, but jbudorick's done some investigation into the existing failing images that suggests that something else might be more likely as the root cause. We're still looking into it.
Project Member

Comment 27 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/05aa89df2d88781bff56cbc80c2551a53143ab93

commit 05aa89df2d88781bff56cbc80c2551a53143ab93
Author: smut <smut@google.com>
Date: Thu Apr 12 03:33:40 2018

Project Member

Comment 28 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/ba63c7280e01e959f6856af2969ff4c0fae8c65d

commit ba63c7280e01e959f6856af2969ff4c0fae8c65d
Author: Jao-ke Chin-Lee <jchinlee@google.com>
Date: Thu Apr 12 03:53:58 2018

Labels: -Pri-1 Pri-0
This is blocking the cq.
#27 reverted our MP image. I'm in the middle of tearing down all of the MP machines on chromium-swarm using the problematic image.
all MP machines on chromium-swarm using the problematic image have been terminated, and most have been reaped. linux-chromeos-rel should be able to chew through its queue overnight.
The bot in the original report (https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29) is now green, so looking good.
Labels: -Pri-0 -Sheriff-Chromium Pri-1
And CQ seems to be fine too. Leaving open for jbudorick@ to verify all is as expected, but lowering prio since the issue seems fixed.
Status: Fixed (was: Assigned)
I think we're all set here. Thanks everyone for your help here. Postmortem to follow.
Issue 831959 has been merged into this issue.
Does this still need to be pushed out to non-gce/mp hosts?
#36: it seemed to only be an issue for MP because we only run the cros tests that were affected there, so I don't think so.

Sign in to add a comment