Issue metadata
Sign in to add a comment
|
Compile failure on Win_asan on official desktop builder with error as "no viable overloaded '+='" |
||||||||||||||||||||||
Issue descriptionLink to builder : https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/933 Link to Error log : https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin-asan%2F933%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Error : FAILED: obj/chrome/common/channel_info/channel_info_win.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\Include\10.0.15063.0\um" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\Include\10.0.15063.0\shared" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\Include\10.0.15063.0\winrt" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\Include\10.0.15063.0\ucrt" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\VC\Tools\MSVC\14.11.25503\include" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\VC\Tools\MSVC\14.11.25503\atlmfc\include" -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DDCHECK_IS_CONFIGURABLE=1 -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -D"CR_CLANG_REVISION=\"328716-2\"" -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DDEPRECATEDENUMERATOR(x)=[[deprecated(x)]] -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen /utf-8 /X -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 -m32 /W4 -Wimplicit-fallthrough -Wthread-safety /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4267 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /Z7 -fno-standalone-debug /MT -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang no-realpath -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare /TP /wd4577 /GR- /c ../../chrome/common/channel_info_win.cc /Foobj/chrome/common/channel_info/channel_info_win.obj /Fd"obj/chrome/common/channel_info_cc.pdb" ../../chrome/common/channel_info_win.cc(20,11): error: no viable overloaded '+=' channel += " DCheck"; ~~~~~~~ ^ ~~~~~~~~~ C:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\VC\Tools\MSVC\14.11.25503\include\xstring(2217,16): note: candidate function not viable: no known conversion from 'const char [8]' to 'initializer_list<wchar_t>' for 1st argument basic_string& operator+=(initializer_list<_Elem> _Ilist) ^ C:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\VC\Tools\MSVC\14.11.25503\include\xstring(2295,16): note: candidate function not viable: no known conversion from 'const char [8]' to 'const std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >' for 1st argument basic_string& operator+=(const basic_string& _Right) ^ C:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\VC\Tools\MSVC\14.11.25503\include\xstring(2307,16): note: candidate function not viable: no known conversion from 'const char [8]' to 'const wchar_t *const' for 1st argument basic_string& operator+=(_In_z_ const _Elem * const _Ptr) ^ C:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\VC\Tools\MSVC\14.11.25503\include\xstring(2312,16): note: candidate function not viable: no known conversion from 'const char [8]' to 'wchar_t' for 1st argument basic_string& operator+=(_Elem _Ch)
,
Apr 11 2018
Re #1: Yes, will do. I'll look into getting the builder renamed to remove the ASAN association.
,
Apr 11 2018
Issue 831702 has been merged into this issue.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed05d62660b3fd83ed7724fbe5609b529f9e31d1 commit ed05d62660b3fd83ed7724fbe5609b529f9e31d1 Author: Wez <wez@chromium.org> Date: Wed Apr 11 20:06:25 2018 Fix string literal in GetChannelName() for official builds. Bug: 812058 , 821764 , 831697 Change-Id: I86759e3ed14cdda2e397f67a23481dd1cf5c7844 Reviewed-on: https://chromium-review.googlesource.com/1007882 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549946} [modify] https://crrev.com/ed05d62660b3fd83ed7724fbe5609b529f9e31d1/chrome/common/channel_info_win.cc
,
Apr 11 2018
,
Apr 12 2018
Strangely, this failed again in tonight's build; the compile failure lists the old code, though, as though this change didn't make it into tonight's Canary branch?
,
Apr 12 2018
yeah, seems like change listed at #4 didn't make it to tonight's canary (67.0.3395.0) : https://chromium.googlesource.com/chromium/src.git/+log/refs/branch-heads/3395 (last change was 17 hrs back) If you can merge the change to 3395, I can retrigger ASAN canary from same branch. Thank you.
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/330c3615157cd58b987a27440fd2abaa1573d3a2 commit 330c3615157cd58b987a27440fd2abaa1573d3a2 Author: Wez <wez@chromium.org> Date: Thu Apr 12 04:58:36 2018 Fix string literal in GetChannelName() for official builds. Bug: 812058 , 821764 , 831697 Change-Id: I86759e3ed14cdda2e397f67a23481dd1cf5c7844 Reviewed-on: https://chromium-review.googlesource.com/1007882 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#549946}(cherry picked from commit ed05d62660b3fd83ed7724fbe5609b529f9e31d1) Reviewed-on: https://chromium-review.googlesource.com/1009126 Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/branch-heads/3395@{#2} Cr-Branched-From: 19ac07e50344cdf4089e5d1b696958867736fc03-refs/heads/master@{#549859} [modify] https://crrev.com/330c3615157cd58b987a27440fd2abaa1573d3a2/chrome/common/channel_info_win.cc
,
Apr 12 2018
Thank you wez@ for quick merge. Build #67.0.3395.2 just got triggered with this merge in.
,
Apr 12 2018
Latest build compiled successfully - https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/935. Side note: There are few unit tests failure reported.
,
Apr 12 2018
Leaving this open for now, to track the base_unittests and unit_tests failures; several are death-tests, so I expect that they are failing because DCHECK isn't FATAL by default in this build.
,
Apr 13 2018
Filed issue 832728 to track the base_unittests and unit_tests failures. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by siggi@chromium.org
, Apr 11 2018