New issue
Advanced search Search tips

Issue 831678 link

Starred by 2 users
Status: Verified
Owner:
mrefaat@chromium.org
Closed: May 2018
Cc:
pkl@chromium.org
srikanthg@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Cookie are not sent by OpenInController

Project Member Reported by eugene...@chromium.org, Apr 11 2018 
App Version (from "Chrome Settings > About Chrome"):M67
iOS Version: All
Device: All

Steps to reproduce: 
1.) Search for a PDF file in your favorite search engine
2.) Tap on PDF link
3.) Tap on loaded PDF document
4.) Tap on Open In...

Observed behavior: 
PDF download request does not send cookie

Expected behavior: 
PDF download request sends cookie
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9abf20e4834015e7cbdb7939e487e80db2eec956

commit 9abf20e4834015e7cbdb7939e487e80db2eec956
Author: Mohammad Refaat <mrefaat@chromium.org>
Date: Tue May 15 20:23:48 2018

Allow URLFetcher to use WKHTTPCookieStore

With iOS11 there is API to access WKHTTPCookieStore and through
WKHTTPSystemCookieStore, URLFetcher can use this api to set and get
cookies from WKHTTPCookieStore

This should fix PDF download problems, it also should allow suggestions
queries to send cookies and will use cookies for NTP tiles.

Bug: 779106,  831678 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I59637ebde557fae09cfd39105d84675724ac0140
Reviewed-on: https://chromium-review.googlesource.com/1050404
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558824}
[modify] https://crrev.com/9abf20e4834015e7cbdb7939e487e80db2eec956/ios/chrome/browser/net/BUILD.gn
[modify] https://crrev.com/9abf20e4834015e7cbdb7939e487e80db2eec956/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/9abf20e4834015e7cbdb7939e487e80db2eec956/ios/chrome/browser/net/cookie_util_unittest.mm

Comment 2 by mrefaat@chromium.org, May 17 2018

Status: Fixed (was: Assigned)

Comment 3 by srikanthg@chromium.org, May 22 2018 

eugenebut/mrefaat: Is this testable manually? From the steps to repro, what is the behavior I should see after step#4?

Comment 4 by eugene...@chromium.org, May 22 2018

Cc: srikanthg@chromium.org
This should be testable manually. Mohammad, do you know examples of web sites which use cookie for authentication?

Comment 5 by mrefaat@chromium.org, May 22 2018 

i was able to test that through gmail PDF attachement - open authenticated
PDF through GMAIL or Drive on the web (from account 1) then share to gmail
app (with account 2)
The PDF should still be readable - if cookies are not working the PDF will
be attached but when opened after sending the email it will be empty file.

Comment 6 by srikanthg@chromium.org, May 22 2018

Status: Verified (was: Fixed)
Thanks for the clarification. that worked.
Verified on M68.0.3437.0 canary
Device: iPhone6s
iOS: 11.4 beta#6

Will verify on more configs as we continue testing.

mrefaat: Can you also clarify if this scenario is covered in Unit/EGTests. If not will add a new testcase to the manual regression test suite.

Comment 7 by eugene...@chromium.org, May 22 2018 

We don't have EG tests for Open In.. feature. Mohammad, can we add a test?

Comment 8 by srikanthg@chromium.org, Jun 15 2018 

Friendly ping

Comment 9 by mrefaat@chromium.org, Jun 20 2018 

I'm putting this on hold for some time, probably to be released around M 70
►

Sign in to add a comment