New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831671 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Site Isolation: Add field trial parameter to disable based on device memory

Project Member Reported by creis@chromium.org, Apr 11 2018

Issue description

As a backup option, we should add an ability to disable Site Isolation field trials for devices below a certain threshold of available memory.  Ideally, the threshold will be something the trial config can specify.
 

Comment 1 by creis@chromium.org, Apr 11 2018

lukasza@, would you be able to help add this, based on our discussions last week?
Status: Started (was: Assigned)
WIP CL @ https://chromium-review.googlesource.com/1008172
Status: Fixed (was: Started)
I think it is okay to mark this as fixed.  I am also trying to follow up on the internal finch-users@ DL to confirm that this CL ends up doing the right thing wrt activation of the experiment groups.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46275d9b9c638584e1bb0053eb3c4be565837d20

commit 46275d9b9c638584e1bb0053eb3c4be565837d20
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu Apr 12 14:57:38 2018

Field trial param to disable site-per-process based on device memory.

Bug:  831671 
Change-Id: Ib0de8b66ebe2963bf25cfde26ab8fef7e1070e56
Reviewed-on: https://chromium-review.googlesource.com/1008172
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550194}
[modify] https://crrev.com/46275d9b9c638584e1bb0053eb3c4be565837d20/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/46275d9b9c638584e1bb0053eb3c4be565837d20/chrome/browser/chrome_content_browser_client_browsertest.cc
[modify] https://crrev.com/46275d9b9c638584e1bb0053eb3c4be565837d20/chrome/common/chrome_features.cc
[modify] https://crrev.com/46275d9b9c638584e1bb0053eb3c4be565837d20/chrome/common/chrome_features.h

Sign in to add a comment