New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831666 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

Establish the scope of an analysis

Project Member Reported by st...@chromium.org, Apr 11 2018

Issue description

Currently, all analyses in Findit are assumed to be:
1. In chromium/src project
2. In master branch
3. Commit has commit position
4. ...

It's better to abstract all of them into a scope like:
<repo-root-url, branch-ref, (git-hash, commit-position)>

In this way, it would be easier to extend to support other branches in chromium/src or support v8, etc.

This is something to be considered in the long term, but worth consideration from now for new feature designs.
 

Comment 1 by st...@chromium.org, Apr 11 2018

Especially, the pair of (git-hash, commit-position) could be added now so that both are available when either is needed.

Comment 2 by st...@chromium.org, Apr 11 2018

In the Luci world, another scope could be:
<luci_project, bucket, repo-root-url, branch-ref, builder>

Sign in to add a comment