The net::DnsConfig struct has a bool edns0 field that claims it enables EDNS0 extensions, but does not appear to actually do anything (https://cs.chromium.org/chromium/src/net/dns/dns_config_service.h?l=92&rcl=bc64fe05b894458c95224232155fdda50d097a53). It appears that there was some musing back in 2011 when it was added about what it could be used for, but nothing came of that (https://codereview.chromium.org/7518028/diff/12006/net/dns/dns_config_service_posix.cc#newcode52). It should probably be removed at this point, since net::DnsTransaction provides a way to enable EDNS0 extensions which should not be confused with this field. Alternatively, this field could be wired up to DnsTransaction such that it actually does enable EDNS0, but I'm not aware of a good justification for doing that.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5048318515c79224ea81adaa15c66121236f3e2 commit c5048318515c79224ea81adaa15c66121236f3e2 Author: Rob Percival <robpercival@chromium.org> Date: Fri Apr 13 10:04:12 2018 Remove edns0 from DnsConfig This does not appear to be used by anything. When it was added in 2011, there was some musing about using it but it seems it never was (https://codereview.chromium.org/7518028/diff/12006/net/dns/dns_config_service_posix.cc#newcode52). Bug: 831665 Change-Id: I1181594cb9f84ba406228075834c4fbfed42a21a Reviewed-on: https://chromium-review.googlesource.com/1007664 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#550571} [modify] https://crrev.com/c5048318515c79224ea81adaa15c66121236f3e2/net/dns/dns_config_service.cc [modify] https://crrev.com/c5048318515c79224ea81adaa15c66121236f3e2/net/dns/dns_config_service.h [modify] https://crrev.com/c5048318515c79224ea81adaa15c66121236f3e2/net/dns/dns_config_service_posix.cc [modify] https://crrev.com/c5048318515c79224ea81adaa15c66121236f3e2/net/dns/dns_config_service_posix_unittest.cc [modify] https://crrev.com/c5048318515c79224ea81adaa15c66121236f3e2/net/dns/fuzzed_host_resolver.cc [modify] https://crrev.com/c5048318515c79224ea81adaa15c66121236f3e2/net/tools/gdig/gdig.cc
Comment 1 by robpercival@chromium.org
, Apr 12 2018Status: Started (was: Untriaged)