Issue metadata
Sign in to add a comment
|
typo in warning when preloading font with meta tag link rel=preload and not using the font
Reported by
liesislu...@gmail.com,
Apr 11 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36 Steps to reproduce the problem: 1. <link rel="preload" href="https://cdnjs.cloudflare.com/ajax/libs/tinymce/4.7.10/skins/lightgray/fonts/tinymce.ttf" as="font"> 2. don't use anywhere this font on page 3. check the console What is the expected behavior? warning message: Please make sure it has an appropriate `as` value and it is preloaded intentionally. What went wrong? typo in message, double first part of the sentence: Please make sure it Please make sure it has an appropriate `as` value and it is preloaded intentionally. Did this work before? N/A Chrome version: 65.0.3325.181 Channel: stable OS Version: OS X 10.13.4 Flash Version: chrome rocks :)
,
Apr 12 2018
Able to reproduce the issue on Mac 10.13.3, Win-10 and Ubuntu 14.04 using chrome reported version #65.0.3325.181 but the same is not reproducible in the latest canary #67.0.3394.0. Reverse Bisect Information: ===================== Good build: 67.0.3381.0 Bad Build : 67.0.3379.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/474e9bf390e7e4262a32c13665cecc05d641ff2f..d3c95fae0e7ccceda86d7b3bb1bf7a1910c52b07 From the above change log suspecting below change Change-Id: I6ad4d15ce7fbf0f168527aaac4029654b6632dd3 Reviewed-on: https://chromium-review.googlesource.com/976186 luoe@ - Could you please check and merge the fix to M-66 if it is a valid candidate. Adding label RBS as it seems to be a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
Apr 12 2018
Thanks for the report. The CL mentioned in comment #2 is not a regression, but a fix for the regression. The typo was introduced in M65 [1] and is now fixed in M67. Given the scope, I don't think this requires merging. [1] https://chromium.googlesource.com/chromium/src/+/585988dafb896f900f565db97d7cc48d78e8801c |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by susan.boorgula@chromium.org
, Apr 11 2018