New issue
Advanced search Search tips

Issue 831661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Remove restriction of unchanging field names during a fill

Project Member Reported by se...@chromium.org, Apr 11 2018

Issue description

Code is here: https://cs.chromium.org/chromium/src/components/autofill/content/renderer/form_autofill_util.cc?sq=package:chromium&dr&l=838-845

There are a few big name sites that do change the name of the field during a fill. 

The classic example is filling a Canadian profile into a page where the default country was the US.

When the country changes, some sites change the "state" field to a "province" field.

This currently stops the Dynamic Form filling from working on those sites.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61a99545b36d8d58bf5ee3929603630eedd2f246

commit 61a99545b36d8d58bf5ee3929603630eedd2f246
Author: sebsg <sebsg@chromium.org>
Date: Thu Apr 12 20:06:31 2018

[AF] Remove restriction of unchanging field names during a fill.

A classic example that will now support is filling a Canadian profile
into a page where the default country was the US.

When the country changes, some sites change the "state" field to a
"province" field.

Bug:  831661 
Change-Id: Iec0deb5ab69f554756a75dd4e893f3535c6bfc06
Reviewed-on: https://chromium-review.googlesource.com/1010528
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550330}
[modify] https://crrev.com/61a99545b36d8d58bf5ee3929603630eedd2f246/chrome/browser/autofill/autofill_interactive_uitest.cc
[add] https://crrev.com/61a99545b36d8d58bf5ee3929603630eedd2f246/chrome/test/data/autofill/field_changing_name_during_fill.html
[modify] https://crrev.com/61a99545b36d8d58bf5ee3929603630eedd2f246/components/autofill/content/renderer/form_autofill_util.cc

Comment 2 by se...@chromium.org, Apr 12 2018

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61a99545b36d8d58bf5ee3929603630eedd2f246

commit 61a99545b36d8d58bf5ee3929603630eedd2f246
Author: sebsg <sebsg@chromium.org>
Date: Thu Apr 12 20:06:31 2018

[AF] Remove restriction of unchanging field names during a fill.

A classic example that will now support is filling a Canadian profile
into a page where the default country was the US.

When the country changes, some sites change the "state" field to a
"province" field.

Bug:  831661 
Change-Id: Iec0deb5ab69f554756a75dd4e893f3535c6bfc06
Reviewed-on: https://chromium-review.googlesource.com/1010528
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550330}
[modify] https://crrev.com/61a99545b36d8d58bf5ee3929603630eedd2f246/chrome/browser/autofill/autofill_interactive_uitest.cc
[add] https://crrev.com/61a99545b36d8d58bf5ee3929603630eedd2f246/chrome/test/data/autofill/field_changing_name_during_fill.html
[modify] https://crrev.com/61a99545b36d8d58bf5ee3929603630eedd2f246/components/autofill/content/renderer/form_autofill_util.cc

Sign in to add a comment