New issue
Advanced search Search tips

Issue 831656 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Improve jankiness in requesting full screen mode

Project Member Reported by dtapu...@chromium.org, Apr 11 2018

Issue description

There are a number of blank frames and multiple layouts on Android.

Work to eliminate these so that the experience appears better.
 
Labels: OS-Android
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5cdaa98071a53cbbf138f0e2c3d93e74770ef86

commit b5cdaa98071a53cbbf138f0e2c3d93e74770ef86
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Apr 12 19:54:57 2018

Improve fullscreen transition jankiness.

Don't evict frames when the width doesn't change to avoid a few frame
repaints that are completely blank. When the size is expanded only
the area that doesn't exist in the old frame appears black.
This is less jarring to the user and appears as less jank.

BUG= 831656 

Change-Id: I787e10d277ffa08ddedd080efa76b984df92c1e1
Reviewed-on: https://chromium-review.googlesource.com/1008245
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550320}
[modify] https://crrev.com/b5cdaa98071a53cbbf138f0e2c3d93e74770ef86/content/browser/renderer_host/render_widget_host_view_android.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5cdaa98071a53cbbf138f0e2c3d93e74770ef86

commit b5cdaa98071a53cbbf138f0e2c3d93e74770ef86
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Apr 12 19:54:57 2018

Improve fullscreen transition jankiness.

Don't evict frames when the width doesn't change to avoid a few frame
repaints that are completely blank. When the size is expanded only
the area that doesn't exist in the old frame appears black.
This is less jarring to the user and appears as less jank.

BUG= 831656 

Change-Id: I787e10d277ffa08ddedd080efa76b984df92c1e1
Reviewed-on: https://chromium-review.googlesource.com/1008245
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550320}
[modify] https://crrev.com/b5cdaa98071a53cbbf138f0e2c3d93e74770ef86/content/browser/renderer_host/render_widget_host_view_android.cc

Status: Fixed (was: Assigned)

Sign in to add a comment