SmartLock setup crashes |
||
Issue descriptionThis appears to have regressed with this commit: https://chromium-review.googlesource.com/c/chromium/src/+/997098 |params_| is never set in the BluetoothSockCloseFunction::Run().
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a725a0097fe4a66c6f7b80ac545a326fe9b9a9f2 commit a725a0097fe4a66c6f7b80ac545a326fe9b9a9f2 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Thu Apr 12 05:30:53 2018 BluetoothSocketCloseFunction: Fix accessing unpopulated params_. CL d06a25798ef3bb7a88276030a64c9af18d424467 stopped using populating |params_| and started using local variables instead. However, one reference to |params_| still remained that is causing null pointer access. Fix this and also remove all bluetooth APIs' params_ where they are currently never used. Add a regression (unit) test as well, along with a small sanity test. Bug: 831651 Test: See bug for repro steps. Change-Id: Ic2df916bb7175563e21c816890bac1c8624d334f Reviewed-on: https://chromium-review.googlesource.com/1008065 Reviewed-by: James Hawkins <jhawkins@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550019} [modify] https://crrev.com/a725a0097fe4a66c6f7b80ac545a326fe9b9a9f2/extensions/browser/BUILD.gn [modify] https://crrev.com/a725a0097fe4a66c6f7b80ac545a326fe9b9a9f2/extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc [modify] https://crrev.com/a725a0097fe4a66c6f7b80ac545a326fe9b9a9f2/extensions/browser/api/bluetooth_socket/bluetooth_socket_api.h [add] https://crrev.com/a725a0097fe4a66c6f7b80ac545a326fe9b9a9f2/extensions/browser/api/bluetooth_socket/bluetooth_socket_api_unittest.cc
,
Apr 12 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by lazyboy@chromium.org
, Apr 11 2018