Issue metadata
Sign in to add a comment
|
VRB: Text spills out of url bar on NTP |
||||||||||||||||||||||||
Issue descriptionChrome Version: ToT (8deb2011eb6bab36c89c832007e43dbceefbb8d1) OS: Android O What steps will reproduce the problem? (1) Open new (incognito) tab (2) Enter VR What is the expected result? URL bar shows text "Search or type web address" and is wide enough to contain this string. What happens instead? The text spills out of the url bar since it is too narrow.
,
Apr 11 2018
,
Apr 11 2018
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1 commit 282cdeeb8baa5b52823ee0ea0cc045cba31e34e1 Author: Christopher Grant <cjgrant@chromium.org> Date: Wed Apr 11 22:32:06 2018 VR: Use layouts for hint text The original URL bar hint text was drawn over the URL bar without being a member of the URL bar's layout. This is fragile, and broke. Now it's simpler and less fragile. Do a bit of URL state cleanup as well. BUG= 831646 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1846d6bee11363ff87c846aca9a4e4ef99430fda Reviewed-on: https://chromium-review.googlesource.com/1008125 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#549952} [modify] https://crrev.com/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1/chrome/browser/vr/model/toolbar_state.cc [modify] https://crrev.com/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1/chrome/browser/vr/model/toolbar_state.h [modify] https://crrev.com/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1/chrome/browser/vr/toolbar_helper.cc [modify] https://crrev.com/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1/chrome/browser/vr/ui_pixeltest.cc [modify] https://crrev.com/282cdeeb8baa5b52823ee0ea0cc045cba31e34e1/chrome/browser/vr/ui_scene_creator.cc
,
Apr 16 2018
,
Apr 16 2018
Verified on build 67.0.3396.3 Canary. Looks good. There is a test case that should cover this already. Adding note to look for issues with all controls/ui elements. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by cjgrant@chromium.org
, Apr 11 2018