Issue 831624

Starred by 1 user

Issue metadata

Status:	Started
Owner:	xiaoh...@chromium.org
Cc:	pbe...@chromium.org alemate@chromium.org newcomer@chromium.org josa...@chromium.org ihf@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Linux
Pri:	1
Type:	Bug
Hotlist-CrOS-Sheriffing M-67

eve-arcnext-chrome-pfq is failing in the PFQ due to libassistant compilation failure

Project Member Reported by newcomer@chromium.org, Apr 11

Back to list

Issue description

After having a red PFQ for a while due to issue 830865 which is now fixed, eve-arcnext-chrome-pfq is broken by this bug:

LINK:
https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Feve-arcnext-chrome-pfq%2F100%2F%2B%2Frecipes%2Fsteps%2FBuildPackages%2F0%2Fstdout


LOGS:
chromeos-chrome-67.0.3394.0_rc-r1: FAILED: obj/libassistant/internal/net/net/udp_socket_posix.o 
chromeos-chrome-67.0.3394.0_rc-r1: /home/chrome-bot/goma/gomacc x86_64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold -MMD -MF obj/libassistant/internal/net/net/udp_socket_posix.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -DCR_CLANG_REVISION=\"328716-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DCR_SYSROOT_HASH=85ac8d5e0f6cff99fc323fd3d29cb73e2aa970e2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/boringssl/src/include -fno-strict-aliasing -fmerge-all-constants -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -no-canonical-prefixes -m64 -march=x86-64 -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf -ggnu-pubnames -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-exceptions -fno-rtti --sysroot=../../../../../../../build/eve-arcnext -fvisibility-inlines-hidden -pipe -pipe -pipe -march=corei7 -fno-split-dwarf-inlining -fdebug-info-for-profiling -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -stdlib=libc++  -c ../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.cc -o obj/libassistant/internal/net/net/udp_socket_posix.o
chromeos-chrome-67.0.3394.0_rc-r1: In file included from ../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.cc:7:
chromeos-chrome-67.0.3394.0_rc-r1: [1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:164:54: [0m[0;1;31merror: [0m[1mexpected class name[0m
chromeos-chrome-67.0.3394.0_rc-r1:   class ReadWatcher : public base::MessageLoopForIO::Watcher {
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                                                     ^
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:170:47: [0m[0;1;31merror: [0m[1monly virtual member functions can be marked 'override'[0m
chromeos-chrome-67.0.3394.0_rc-r1:     void OnFileCanReadWithoutBlocking(int fd) override;
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                                              ^~~~~~~~
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:172:48: [0m[0;1;31merror: [0m[1monly virtual member functions can be marked 'override'[0m
chromeos-chrome-67.0.3394.0_rc-r1:     void OnFileCanWriteWithoutBlocking(int fd) override {}
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                                               ^~~~~~~~~
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:180:55: [0m[0;1;31merror: [0m[1mexpected class name[0m
chromeos-chrome-67.0.3394.0_rc-r1:   class WriteWatcher : public base::MessageLoopForIO::Watcher {
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                                                      ^
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:186:47: [0m[0;1;31merror: [0m[1monly virtual member functions can be marked 'override'[0m
chromeos-chrome-67.0.3394.0_rc-r1:     void OnFileCanReadWithoutBlocking(int fd) override {}
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                                              ^~~~~~~~~
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:188:48: [0m[0;1;31merror: [0m[1monly virtual member functions can be marked 'override'[0m
chromeos-chrome-67.0.3394.0_rc-r1:     void OnFileCanWriteWithoutBlocking(int fd) override;
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                                               ^~~~~~~~
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:240:27: [0m[0;1;31merror: [0m[1mno type named 'FileDescriptorWatcher' in 'base::MessageLoopForIO'[0m
chromeos-chrome-67.0.3394.0_rc-r1:   base::MessageLoopForIO::FileDescriptorWatcher read_socket_watcher_;
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m  ~~~~~~~~~~~~~~~~~~~~~~~~^
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:241:27: [0m[0;1;31merror: [0m[1mno type named 'FileDescriptorWatcher' in 'base::MessageLoopForIO'[0m
chromeos-chrome-67.0.3394.0_rc-r1:   base::MessageLoopForIO::FileDescriptorWatcher write_socket_watcher_;
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m  ~~~~~~~~~~~~~~~~~~~~~~~~^
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.cc:166:26: [0m[0;1;31merror: [0m[1mno member named 'WATCH_READ' in 'base::MessageLoopForIO'; did you mean 'base::MessagePumpLibevent::WATCH_READ'?[0m
chromeos-chrome-67.0.3394.0_rc-r1:           socket_, true, base::MessageLoopForIO::WATCH_READ,
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chromeos-chrome-67.0.3394.0_rc-r1: [0m[0;32m                         base::MessagePumpLibevent::WATCH_READ
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/base/message_loop/watchable_io_message_pump_posix.h:56:5: [0m[0;1;30mnote: [0m'base::MessagePumpLibevent::WATCH_READ' declared here[0m
chromeos-chrome-67.0.3394.0_rc-r1:     WATCH_READ = 1 << 0,
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m    ^
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.cc:208:26: [0m[0;1;31merror: [0m[1mno member named 'WATCH_WRITE' in 'base::MessageLoopForIO'; did you mean 'base::MessagePumpLibevent::WATCH_WRITE'?[0m
chromeos-chrome-67.0.3394.0_rc-r1:           socket_, true, base::MessageLoopForIO::WATCH_WRITE,
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chromeos-chrome-67.0.3394.0_rc-r1: [0m[0;32m                         base::MessagePumpLibevent::WATCH_WRITE
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/base/message_loop/watchable_io_message_pump_posix.h:57:5: [0m[0;1;30mnote: [0m'base::MessagePumpLibevent::WATCH_WRITE' declared here[0m
chromeos-chrome-67.0.3394.0_rc-r1:     WATCH_WRITE = 1 << 1,
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m    ^
chromeos-chrome-67.0.3394.0_rc-r1: [0mIn file included from ../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.cc:7:
chromeos-chrome-67.0.3394.0_rc-r1: [1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:240:49: [0m[0;1;35mwarning: [0m[1mprivate field 'read_socket_watcher_' is not used [-Wunused-private-field][0m
chromeos-chrome-67.0.3394.0_rc-r1:   base::MessageLoopForIO::FileDescriptorWatcher read_socket_watcher_;
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                                                ^
chromeos-chrome-67.0.3394.0_rc-r1: [0m[1m../../../../../../../home/chrome-bot/chrome_root/src/libassistant/internal/net/socket/udp_socket_posix.h:241:49: [0m[0;1;35mwarning: [0m[1mprivate field 'write_socket_watcher_' is not used [-Wunused-private-field][0m
chromeos-chrome-67.0.3394.0_rc-r1:   base::MessageLoopForIO::FileDescriptorWatcher write_socket_watcher_;
chromeos-chrome-67.0.3394.0_rc-r1: [0;1;32m                                                ^
chromeos-chrome-67.0.3394.0_rc-r1: [0m2 warnings and 10 errors generated.

Comment 1 by xiaoh...@chromium.org, Apr 11

Status: Started

https://libassistant-internal-review.git.corp.google.com/c/libassistant/internal/+/39242
https://libassistant-internal-review.git.corp.google.com/c/libassistant/internal/+/39241

These two CLs should fix it.  But we need to coordinate with the Cast team to fix it in their repo too.

Comment 2 by pbe...@chromium.org, Apr 12

Cc: pbe...@chromium.org

Comment 3 by ihf@chromium.org, Apr 12

Cc: ihf@chromium.org
Labels: -Pri-3 M-67 Pri-1

Comment 4 by xiaoh...@chromium.org, Apr 12

Update, waiting for ChromeCast team to merge their side and also including this fix. Looks like merging very soon. https://eureka-internal-review.git.corp.google.com/c/chromium/src/+/161818

Comment 5 by pbe...@chromium.org, Apr 16 (3 days ago)

Labels: Hotlist-CrOS-Sheriffing

►