New issue
Advanced search Search tips

Issue 831610 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Enable 6DoF tracking in VRShell

Project Member Reported by bajones@chromium.org, Apr 11 2018

Issue description

On devices like the upcoming Lenovo Mirage Solo the users head position is tracked in addition to rotation. (6DoF tracking) VRShell's rendering methods make it easily adaptable to 6DoF, so we should enable it for devices that support it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d28e6bc86503d614b10f6fdefe79132ae1b0faa

commit 2d28e6bc86503d614b10f6fdefe79132ae1b0faa
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Apr 13 16:29:57 2018

Enable 6DoF head tracking on Daydream devices that support it.

Change-Id: I32144548e5427a1e50491259dadf729a743a54df
Bug:  831610 
Reviewed-on: https://chromium-review.googlesource.com/1000134
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550638}
[modify] https://crrev.com/2d28e6bc86503d614b10f6fdefe79132ae1b0faa/chrome/android/java/AndroidManifest.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d28e6bc86503d614b10f6fdefe79132ae1b0faa

commit 2d28e6bc86503d614b10f6fdefe79132ae1b0faa
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Apr 13 16:29:57 2018

Enable 6DoF head tracking on Daydream devices that support it.

Change-Id: I32144548e5427a1e50491259dadf729a743a54df
Bug:  831610 
Reviewed-on: https://chromium-review.googlesource.com/1000134
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550638}
[modify] https://crrev.com/2d28e6bc86503d614b10f6fdefe79132ae1b0faa/chrome/android/java/AndroidManifest.xml

Project Member

Comment 3 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7f760bc7de54fb5cd1c88b6165b9dea11b45768

commit e7f760bc7de54fb5cd1c88b6165b9dea11b45768
Author: Brandon Jones <bajones@chromium.org>
Date: Tue May 15 21:14:10 2018

Fix the controller being locked in place with 6DoF systems

gvr's Arm model apparently does not take into account the user's head position
on 6DoF systems, leaving the arm model "locked" in place near the origin. This
change manually offsets the controller model by the head's position so that the
arm model for the controller stays at a constant relative position to the head.
This yields behavior that matches Google's other first-party VR applications.

Bug:  831610 
Change-Id: Id5cf7013c5b671e320304cd78bc80abd11580300
Reviewed-on: https://chromium-review.googlesource.com/1058558
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558833}
[modify] https://crrev.com/e7f760bc7de54fb5cd1c88b6165b9dea11b45768/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/e7f760bc7de54fb5cd1c88b6165b9dea11b45768/chrome/browser/android/vr/vr_controller.h
[modify] https://crrev.com/e7f760bc7de54fb5cd1c88b6165b9dea11b45768/chrome/browser/android/vr/vr_shell_gl.cc

Status: Fixed (was: Started)

Sign in to add a comment