New issue
Advanced search Search tips

Issue 831609 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

gn silently allows duplicate tools in a toolchain, and silently ignores .c files if the "cc" tool is missing

Project Member Reported by thakis@chromium.org, Apr 11 2018

Issue description

I was writing a new toolchain recently. I started with just the "cxx" tool.

I then discovered that gn silently ignores .c files in sources if there's no cc tool -- maybe it should say ".c file in sources but no cc file in toolchain?"

So I went and copied my cxx tool with the intent of creating a cc tool -- I changed c++ to cc in the command, but forgot to actually change the tool name from cxx to cc, so now my toolchain had two cxx tools but still no cc file. gn again did not diagnose this but just silently kept ignoring my c files. gn should probably also warn (or even error) on tool redefinitions.

Not terribly important since people probably don't write toolchains frequently, but I figured I should at least file a bug.
 

Comment 1 by pkl@chromium.org, Apr 30 2018

Cc: sdefresne@chromium.org
Status: Available (was: Untriaged)
Don't know where GN bugs would go.
Labels: -OS-Linux -OS-Android -OS-Windows -OS-iOS -OS-Chrome -OS-Mac -OS-Fuchsia
It's in the right place, component=Build, Label=Build-Tools-GN.

OS-agnostic bugs like this one should have no OS boxes checked, not all of them.

Sign in to add a comment