New issue
Advanced search Search tips

Issue 831601 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 831328



Sign in to add a comment

Address size jumps that occurred when binary size alerts were broken

Project Member Reported by estevenson@chromium.org, Apr 11 2018

Issue description

Labels: -Type-Bug Type-Task
Only 2 jumps over 16 kb that I can see! 

https://chromeperf.appspot.com/report?sid=d6542096534166992e063320f8e1b7128e10ed53091e865eef3b5295644e60ce&start_rev=549673&end_rev=549884 shows a 64 kb regression caused by ddd73e54df17c4c75566f55cecb13a40c1e26608 (AFDO roll -not actionable).

https://chromeperf.appspot.com/report?sid=d6542096534166992e063320f8e1b7128e10ed53091e865eef3b5295644e60ce&start_rev=548861&end_rev=549550 shows a 91 kb regression but this was when the builder was broken. I'll need to bisect this via diagnose_bloat.py to see if there were any big jumps.

Huge jump for 16e808d789d05fcc2bfcc8b00e002d11405adb1a but that cl was reverted. 
I ran diagnose_bloat.py for every 5 commits in the range (~100 of ~500 commits) and there was only 1 jump over 16kb, 36kb for an AFDO role https://chromium-review.googlesource.com/1001473.

Maybe I'll let it run over the weekend for every commit..
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb962bff7f98a641b4cbdeaefe5b82c280591961

commit bb962bff7f98a641b4cbdeaefe5b82c280591961
Author: Eric Stevenson <estevenson@chromium.org>
Date: Fri Apr 13 19:19:30 2018

diagnose_bloat.py: Add features for large rolls.

This CL adds the --step flag to make debugging large rolls more
efficient.

Also adds the --apply-patch flag to give users the ability to apply
local patches before performing each build (not compatible with
--cloud). Note that this doesn't work for patches to supersize; we copy
supersize to a temp dir before modifying local state.

Side note: using diagnose_bloat.py with CLs before and after the blink
rename require "git config merge.renamelimit 20000".

Bug:  831601 
Change-Id: Ida5d0a879355e48c942dab07afd5489c36bca1ca
Reviewed-on: https://chromium-review.googlesource.com/1011681
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550714}
[modify] https://crrev.com/bb962bff7f98a641b4cbdeaefe5b82c280591961/tools/binary_size/diagnose_bloat.py

Status: Fixed (was: Assigned)
Didn't end up running this over the weekend but I think we're likely okay here.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb962bff7f98a641b4cbdeaefe5b82c280591961

commit bb962bff7f98a641b4cbdeaefe5b82c280591961
Author: Eric Stevenson <estevenson@chromium.org>
Date: Fri Apr 13 19:19:30 2018

diagnose_bloat.py: Add features for large rolls.

This CL adds the --step flag to make debugging large rolls more
efficient.

Also adds the --apply-patch flag to give users the ability to apply
local patches before performing each build (not compatible with
--cloud). Note that this doesn't work for patches to supersize; we copy
supersize to a temp dir before modifying local state.

Side note: using diagnose_bloat.py with CLs before and after the blink
rename require "git config merge.renamelimit 20000".

Bug:  831601 
Change-Id: Ida5d0a879355e48c942dab07afd5489c36bca1ca
Reviewed-on: https://chromium-review.googlesource.com/1011681
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550714}
[modify] https://crrev.com/bb962bff7f98a641b4cbdeaefe5b82c280591961/tools/binary_size/diagnose_bloat.py

Sign in to add a comment