Address size jumps that occurred when binary size alerts were broken |
|||
Issue descriptionAndroid binary size alerts were broken from April 4-11. Approximate range: https://chromeperf.appspot.com/report?sid=d6542096534166992e063320f8e1b7128e10ed53091e865eef3b5295644e60ce&start_rev=548074&end_rev=549880.
,
Apr 13 2018
I ran diagnose_bloat.py for every 5 commits in the range (~100 of ~500 commits) and there was only 1 jump over 16kb, 36kb for an AFDO role https://chromium-review.googlesource.com/1001473. Maybe I'll let it run over the weekend for every commit..
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb962bff7f98a641b4cbdeaefe5b82c280591961 commit bb962bff7f98a641b4cbdeaefe5b82c280591961 Author: Eric Stevenson <estevenson@chromium.org> Date: Fri Apr 13 19:19:30 2018 diagnose_bloat.py: Add features for large rolls. This CL adds the --step flag to make debugging large rolls more efficient. Also adds the --apply-patch flag to give users the ability to apply local patches before performing each build (not compatible with --cloud). Note that this doesn't work for patches to supersize; we copy supersize to a temp dir before modifying local state. Side note: using diagnose_bloat.py with CLs before and after the blink rename require "git config merge.renamelimit 20000". Bug: 831601 Change-Id: Ida5d0a879355e48c942dab07afd5489c36bca1ca Reviewed-on: https://chromium-review.googlesource.com/1011681 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550714} [modify] https://crrev.com/bb962bff7f98a641b4cbdeaefe5b82c280591961/tools/binary_size/diagnose_bloat.py
,
Apr 16 2018
Didn't end up running this over the weekend but I think we're likely okay here.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb962bff7f98a641b4cbdeaefe5b82c280591961 commit bb962bff7f98a641b4cbdeaefe5b82c280591961 Author: Eric Stevenson <estevenson@chromium.org> Date: Fri Apr 13 19:19:30 2018 diagnose_bloat.py: Add features for large rolls. This CL adds the --step flag to make debugging large rolls more efficient. Also adds the --apply-patch flag to give users the ability to apply local patches before performing each build (not compatible with --cloud). Note that this doesn't work for patches to supersize; we copy supersize to a temp dir before modifying local state. Side note: using diagnose_bloat.py with CLs before and after the blink rename require "git config merge.renamelimit 20000". Bug: 831601 Change-Id: Ida5d0a879355e48c942dab07afd5489c36bca1ca Reviewed-on: https://chromium-review.googlesource.com/1011681 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550714} [modify] https://crrev.com/bb962bff7f98a641b4cbdeaefe5b82c280591961/tools/binary_size/diagnose_bloat.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by estevenson@chromium.org
, Apr 11 2018