obbs_fyi try builder fails to access service-account-chrome-perf-ci-builder.json credential |
|||
Issue descriptionThis try builder in tryserver.chromium.perf shares the swarming bots with "One Buildbot Step Test Builder" builder in chromium.perf.fyi. As we convert the "One Buildbot Step Test Builder" builder to use bots in private swarming server ( issue 830957 ), so is the "obbs_fyi" try builder. However, this builder is having issue with accessing the credential file in /creds/service_accounts/service-account-chrome-perf-ci-builder.json Vadim: you know what may be going on here? Build log: https://luci-milo.appspot.com/buildbot/tryserver.chromium.perf/obbs_fyi/295 Slave id: slave1584-c4 *I set this as P1 because this is the only CQ testing we have for the integration of the new perf recipe on source side.
,
Apr 12 2018
I don't feel comfortable reusing chrome-perf-ci-builder account (which was supposed to be used only from CI builders) on try server. This feels like a start of debt accumulation. I propose: 1. Create new account chrome-perf-buildbot to be used during the migration from Buildbot (both try and CI). 2. Deploy it on all perf builders. 3. Modify Swarming/Isolate ACLs to accept it. 4. Modify perf recipes to use it instead of chrome-perf-ci-builder. Does this sound OK? If so, I can do this.
,
Apr 12 2018
This sounds OK to me. Thanks Vadim!
,
Apr 12 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/6a78a860505f9b005dba984e4fb9110e16142a0a commit 6a78a860505f9b005dba984e4fb9110e16142a0a Author: Vadim Shtayura <vadimsh@chromium.org> Date: Thu Apr 12 01:34:10 2018
,
Apr 12 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/3759c9fd4b130670b7222595d51273a0867045e8 commit 3759c9fd4b130670b7222595d51273a0867045e8 Author: Vadim Shtayura <vadimsh@chromium.org> Date: Thu Apr 12 01:35:45 2018
,
Apr 12 2018
Necessary config changes are in, but puppet change will need few hours to propagate. https://chromium-review.googlesource.com/c/chromium/tools/build/+/1009065 can be landed e.g. tomorrow morning and it should work. Then we'll need to cleanup old account/permissions.
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/5263525a83d8ab797279d6bfb68c5d6e4c56e6b6 commit 5263525a83d8ab797279d6bfb68c5d6e4c56e6b6 Author: Nghia Nguyen <nednguyen@google.com> Date: Thu Apr 12 17:45:22 2018 Update perf builders to use chrome-perf-buildbot for accessing private swarming/isolate server Bug:831588 Change-Id: Ia2a40647cc22643baded94feed493c1bc233a6d6 Reviewed-on: https://chromium-review.googlesource.com/1009065 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> [modify] https://crrev.com/5263525a83d8ab797279d6bfb68c5d6e4c56e6b6/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
,
Apr 12 2018
Can you confirm new account works?
,
Apr 12 2018
The new account seems to work for ci builder. I just kicked off a try run in https://ci.chromium.org/buildbot/tryserver.chromium.perf/obbs_fyi/301
,
Apr 12 2018
Great! If it works, I'll start removing the old account.
,
Apr 12 2018
It works. The test in try builder triggered & run fine. Thanks Vadim! |
|||
►
Sign in to add a comment |
|||
Comment 1 by nedngu...@google.com
, Apr 11 2018