New issue
Advanced search Search tips

Issue 831587 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: May 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Popup Menu: Add accessibility label on the scrim

Project Member Reported by gambard@chromium.org, Apr 11 2018 
The scrim behind the popup menu should have an accessibility label to let the user know it is possible to dismiss the menu.
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc2fe9d20b1c3088a7f1411d5f13e2b4ec61791e

commit fc2fe9d20b1c3088a7f1411d5f13e2b4ec61791e
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon May 14 15:52:33 2018

Add accessibility for PopupMenu

This CL adds the accessibility labels and ordering for the popup menus.

Bug: 833425, 842032,  831587 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I06bd6821144aee96c47374fd44e4a811831fc704
Reviewed-on: https://chromium-review.googlesource.com/1057307
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558325}
[modify] https://crrev.com/fc2fe9d20b1c3088a7f1411d5f13e2b4ec61791e/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/fc2fe9d20b1c3088a7f1411d5f13e2b4ec61791e/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm
[modify] https://crrev.com/fc2fe9d20b1c3088a7f1411d5f13e2b4ec61791e/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm

Comment 2 by gambard@chromium.org, May 14 2018

NextAction: 2018-05-23

Comment 3 by gambard@chromium.org, May 14 2018

Status: Fixed (was: Assigned)

Comment 4 by monor...@bugs.chromium.org, May 23 2018 

The NextAction date has arrived: 2018-05-23
►

Sign in to add a comment