win7_chromium_rel_ng is having infra failures when layout tests are run |
|||||||
Issue descriptionSee e.g. https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/143262 Looking at the bot's recent builds, it appears that whenever it needs to run layout tests it ends up throwing an exception at the end: Traceback (most recent call last): File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\run.py", line 287, in _new_run recipe_result = recipe_script.run(api, self.properties, self.environ) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 98, in run self.run_steps, properties, environ, self.PROPERTIES, api=api) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 626, in invoke_with_properties arg_names, **additional_args) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 589, in _invoke_with_properties return callable_obj(*props, **additional_args) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipes\chromium_trybot.py", line 45, in RunSteps return api.chromium_tests.trybot_steps() File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner return func(*a, **kw) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipe_modules\chromium_tests\api.py", line 881, in trybot_steps affected_files, disable_deapply_patch=disable_deapply_patch) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner return func(*a, **kw) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipe_modules\chromium_tests\api.py", line 727, in run_tests_on_tryserver self.m, tests, deapply_patch_fn) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner return func(*a, **kw) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipe_modules\test_utils\api.py", line 147, in determine_new_failures failing_tests = self.run_tests_with_patch(caller_api, tests) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner return func(*a, **kw) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipe_modules\test_utils\api.py", line 116, in run_tests_with_patch failing_tests = self.run_tests(caller_api, tests, 'with patch') File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner return func(*a, **kw) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipe_modules\test_utils\api.py", line 105, in run_tests t.post_run(caller_api, suffix) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipe_modules\chromium_tests\steps.py", line 1817, in post_run super(SwarmingIsolatedScriptTest, self).post_run(api, suffix) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipe_modules\chromium_tests\steps.py", line 1480, in post_run valid, failures = self.validate_task_results(api, api.step.active_result) File "C:\b\rr\tmpaoqpzv\rw\checkout\scripts/slave\recipe_modules\chromium_tests\steps.py", line 1788, in validate_task_results presentation = step_result.presentation AttributeError: 'NoneType' object has no attribute 'presentation'
,
Apr 11 2018
,
Apr 11 2018
,
Apr 11 2018
,
Apr 11 2018
Does something need a restart? I'm still seeing the same failure with https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/143564
,
Apr 11 2018
This isn't fixed. The CLs I landed were intended to get to the root issue.
,
Apr 11 2018
blocking almost all CLs from landing.
,
Apr 11 2018
I'm disabling the layout tests on windows due to this.
,
Apr 11 2018
... or at least on win7_chromium_rel_ng.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/644f117defdf85acdb126d1209e79fa25051c63e commit 644f117defdf85acdb126d1209e79fa25051c63e Author: John Budorick <jbudorick@chromium.org> Date: Wed Apr 11 19:25:42 2018 Stop mirroring the WebKit Win7 on win7_chromium_rel_ng. TBR=hzl@chromium.org,dpranke@chromium.org Bug: 831585 Change-Id: Ie2e5329750f4b3503c475706fd5a7aa69643e5ec Reviewed-on: https://chromium-review.googlesource.com/1008067 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/644f117defdf85acdb126d1209e79fa25051c63e/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json [modify] https://crrev.com/644f117defdf85acdb126d1209e79fa25051c63e/scripts/slave/recipe_modules/chromium_tests/tests/api/deapply_patch.expected/basic.json [modify] https://crrev.com/644f117defdf85acdb126d1209e79fa25051c63e/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json [modify] https://crrev.com/644f117defdf85acdb126d1209e79fa25051c63e/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/644f117defdf85acdb126d1209e79fa25051c63e/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
,
Apr 11 2018
landing https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1008166 which should let us re-enable the tests, hopefully.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/recipes-py/+/c56929b29c60fcaba3ee5d89da10c5e35ef03884 commit c56929b29c60fcaba3ee5d89da10c5e35ef03884 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Apr 11 20:59:37 2018 [raw_io] Add UNC magic prefix on win32 to handle long paths. R=jbudorick@chromium.org, maruel@chromium.org Bug: 831585 Change-Id: I30cc3e20f5ba7c34cf35f4109df6d7e850a1bb6e Reviewed-on: https://chromium-review.googlesource.com/1008166 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/c56929b29c60fcaba3ee5d89da10c5e35ef03884/recipe_modules/raw_io/api.py
,
Apr 11 2018
Cool. I will re-enable the test later today.
,
Apr 11 2018
Please do not do that for now.
,
Apr 11 2018
OK. Since the remaining task is to reable the test, and nothing is broken anymore, it should not be a P0 anymore.
,
Apr 11 2018
Let me open a new bug just for re-enable the tests and close this one.
,
Apr 11 2018
Bug created here: https://bugs.chromium.org/p/chromium/issues/detail?id=831847
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7a83cd8efeaf932ae023f3d961b70bd3e0ab5b1 commit d7a83cd8efeaf932ae023f3d961b70bd3e0ab5b1 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Apr 26 01:21:52 2018 Re-add layout tests to win7 bot Bug: 831585 Change-Id: I3436ca3abe39a648a150d703173715f69756e508 Reviewed-on: https://chromium-review.googlesource.com/1028009 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#553868} [modify] https://crrev.com/d7a83cd8efeaf932ae023f3d961b70bd3e0ab5b1/testing/buildbot/chromium.win.json [modify] https://crrev.com/d7a83cd8efeaf932ae023f3d961b70bd3e0ab5b1/testing/buildbot/test_suite_exceptions.pyl
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aac2bcc130900561b460ddc60ae13031846076f9 commit aac2bcc130900561b460ddc60ae13031846076f9 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Apr 26 22:12:55 2018 Revert "Re-add layout tests to win7 bot" This reverts commit d7a83cd8efeaf932ae023f3d961b70bd3e0ab5b1. Reason for revert: bots are still infra failing Original change's description: > Re-add layout tests to win7 bot > > Bug: 831585 > Change-Id: I3436ca3abe39a648a150d703173715f69756e508 > Reviewed-on: https://chromium-review.googlesource.com/1028009 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553868} TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org Change-Id: I4d08d6e21a0ac4622d7a936ff92a5bd795d5af13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831585 Reviewed-on: https://chromium-review.googlesource.com/1031530 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#554165} [modify] https://crrev.com/aac2bcc130900561b460ddc60ae13031846076f9/testing/buildbot/chromium.win.json [modify] https://crrev.com/aac2bcc130900561b460ddc60ae13031846076f9/testing/buildbot/test_suite_exceptions.pyl
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/109eed414a06aaae92ef600c28c71f2415a52085 commit 109eed414a06aaae92ef600c28c71f2415a52085 Author: Stephen Martinis <martiniss@chromium.org> Date: Fri Apr 27 21:12:12 2018 Reland "Re-add layout tests to win7 bot" This reverts commit aac2bcc130900561b460ddc60ae13031846076f9. Reason for revert: Windows path issues hopefully fixed Original change's description: > Revert "Re-add layout tests to win7 bot" > > This reverts commit d7a83cd8efeaf932ae023f3d961b70bd3e0ab5b1. > > Reason for revert: bots are still infra failing > > Original change's description: > > Re-add layout tests to win7 bot > > > > Bug: 831585 > > Change-Id: I3436ca3abe39a648a150d703173715f69756e508 > > Reviewed-on: https://chromium-review.googlesource.com/1028009 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553868} > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > Change-Id: I4d08d6e21a0ac4622d7a936ff92a5bd795d5af13 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 831585 > Reviewed-on: https://chromium-review.googlesource.com/1031530 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554165} TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org Change-Id: I13aa35358d093b09b14125ffe62535ddc4c77ffd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831847 Reviewed-on: https://chromium-review.googlesource.com/1033792 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#554509} [modify] https://crrev.com/109eed414a06aaae92ef600c28c71f2415a52085/testing/buildbot/chromium.win.json [modify] https://crrev.com/109eed414a06aaae92ef600c28c71f2415a52085/testing/buildbot/test_suite_exceptions.pyl |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by raphael....@intel.com
, Apr 11 2018Labels: -Pri-2 Pri-1