New issue
Advanced search Search tips

Issue 831582 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Redirecting from iframe causes New Tab Page opening and redirecting current Tab Page

Reported by spi...@ecwid.com, Apr 11 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Example URL:
http://lamp.ecwid.com/~spider/test-iframe.html

Steps to reproduce the problem:
1. visit http://lamp.ecwid.com/~spider/test-iframe.html
2. put fruit->cherry product into the shopping cart
3. open shopping cart page
4. click PayPal Express button

What is the expected behavior?
redirecting to PayPal Express Checkout

What went wrong?
Browser tries to open PayPal Express Checkout page in new Tab Page and in current tab page that causes blocked redirecting

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes 65.0.3325.181

Does this work in other browsers? Yes

Chrome version: 67.0.3393.0  Channel: canary
OS Version: OS X 10.13.3
Flash Version: 

https://monosnap.com/file/cCQzbbBVE7n4DrNdH8WR3tUvjtwrXV
 

Comment 1 by woxxom@gmail.com, Apr 11 2018

That button tries to navigate the main page to a new URL (aka "iframe busting") and Chrome prevents it, other browsers don't.

Comment 2 by spi...@ecwid.com, Apr 11 2018

And why Chrome tries to open a new Tab Page during redirecting main page? Is that correct?

Comment 3 by spi...@ecwid.com, Apr 11 2018

"in Chrome 64 all redirects originating from third-party iframes will show an infobar instead of redirecting, unless the user had been interacting with that frame.

When the user interacts with content, things can also go wrong. One example that causes user frustration is when clicking a link opens the desired destination in a new tab, while the main window navigates to a different, unwanted page. Starting in Chrome 65 we'll also detect this behavior, trigger an infobar, and prevent the main tab from being redirected."

It seems to me Chrome prevents that redirecting because of browser opens a new tab and navigates main page at the same time. But we don't create a new tab. We use only target="_top" to redirect main page from iframe.

Comment 4 by woxxom@gmail.com, Apr 11 2018

The site tries frame-busting and when it fails it proceeds with window.open() which is blocked by default in Chrome by the popup policy.
Components: -Blink UI>Browser>Navigation
Labels: Needs-Bisect Needs-Triage-M67
Cc: susan.boorgula@chromium.org
Labels: -Type-Bug -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 Target-67 FoundIn-67 OS-Linux OS-Windows Pri-1 Type-Bug-Regression
Owner: japhet@chromium.org
Status: Assigned (was: Unconfirmed)
spider@ Thanks for the issue.

Able to reproduce this issue on Windows 10, Mac OS 10.12.6 and Ubuntu 14.04 on the latest Canary 67.0.3394.0 as per the original comment.

Bisect Information:
===================
Good Build: 67.0.3381.0 (Revision - 545918)
Bad Build : 67.0.3382.0 (Revision - 546346)

On executing the per-revision bisect script, below is the Changelog URL:

https://chromium.googlesource.com/chromium/src/+log/5d97f053b583d59396b6e0a154e7ba6486871d2d..64f4e318af57a8e47a606980b86b2b593d3ad8ec

From the above Changelog, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/941615

japhet@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Adding ReleaseBlock-Stable as this is a recent regression. Please feel free to remove if it is not applicable.

Thanks.

Comment 8 by gov...@chromium.org, Apr 25 2018

M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.


*** Bulk Edit ***
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
Labels: -M-67 M-68
This feature was disabled for m67, pushing to m68
Labels: -Target-67 Target-68
Applying "Target-68" per comment #10.
Status: Fixed (was: Assigned)
This appears to be working correctly for me in M68. Manually allowing the redirect navigates the current tab and doesn't open a new tab.

If you're still seeing this issue, please feel free to reply here and I'll take another look.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment