[Mac Enterprise] All channels should obey the same policies |
|||
Issue descriptionEnterprise policies are per bundle ID. Right now, we have the Stable/Beta/Dev channels with the bundle ID "com.google.Chrome" and "com.google.Chrome.canary", and thus they follow different sets of policies. This is a problem: 1. This differs from other platforms. 2. With the implementation of SxS Chrome, different channels will be getting different bundle IDs, and thus this problem will be exacerbated. The situation we want to get into is where all channels obey all the same policies, the ones set on "com.google.Chrome". --- While messaging can help us be less disruptive, it would be the best if we could assist in the design choice we make here. An easy win could possibly be CFPreferencesAddSuitePreferencesToApp(), which would mean that all Chrome channels would pull policies from "com.google.Chrome" *as well as* policies from what ever bundle ID they are. On the other hand, there are concerns about conflicts.
,
Apr 12 2018
A question about ChromeBrowserPolicyConnector. Is that used in all builds or just Chrome builds? Perhaps we only use com.google.Chrome for Chrome builds and let it be for Chromium/other builds?
,
Apr 13 2018
On Windows, Chromium builds use a different set of policies: policy::kRegistryChromePolicyKey is SOFTWARE\Policies\Chromium rather than SOFTWARE\Policies\Google\Chrome. I think we should do the same for macOS: Chromium reads from one place and all Google Chrome channels from another.
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e21e0b54de518d58507a2c8492a131607696690 commit 5e21e0b54de518d58507a2c8492a131607696690 Author: Avi Drissman <avi@chromium.org> Date: Mon Apr 16 18:00:30 2018 Always load managed preferences from under the stable bundle ID. BUG= 831577 Change-Id: Iaee76e352162b0afcbe61b9ee62c5db5ef9adc7f Reviewed-on: https://chromium-review.googlesource.com/1008544 Reviewed-by: Georges Khalil <georgesak@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551031} [modify] https://crrev.com/5e21e0b54de518d58507a2c8492a131607696690/chrome/browser/policy/chrome_browser_policy_connector.cc
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e21e0b54de518d58507a2c8492a131607696690 commit 5e21e0b54de518d58507a2c8492a131607696690 Author: Avi Drissman <avi@chromium.org> Date: Mon Apr 16 18:00:30 2018 Always load managed preferences from under the stable bundle ID. BUG= 831577 Change-Id: Iaee76e352162b0afcbe61b9ee62c5db5ef9adc7f Reviewed-on: https://chromium-review.googlesource.com/1008544 Reviewed-by: Georges Khalil <georgesak@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551031} [modify] https://crrev.com/5e21e0b54de518d58507a2c8492a131607696690/chrome/browser/policy/chrome_browser_policy_connector.cc
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0104f8b9ff36f8c255729a4271d077cae1500c43 commit 0104f8b9ff36f8c255729a4271d077cae1500c43 Author: Avi Drissman <avi@chromium.org> Date: Fri Apr 20 14:38:49 2018 Have PolicyLoaderMac copy the bundle id. PolicyLoaderMac needs it for a while and needs to ensure it doesn't change, so have it make a copy. BUG= 834005 , 831577 Change-Id: I472aa355770c2a938343b4f230a034387b2711b2 Reviewed-on: https://chromium-review.googlesource.com/1019354 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#552331} [modify] https://crrev.com/0104f8b9ff36f8c255729a4271d077cae1500c43/components/policy/core/common/policy_loader_mac.h [modify] https://crrev.com/0104f8b9ff36f8c255729a4271d077cae1500c43/components/policy/core/common/policy_loader_mac.mm
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fa568a41b3745d0876928c9352e541d1e015bd1 commit 6fa568a41b3745d0876928c9352e541d1e015bd1 Author: Avi Drissman <avi@chromium.org> Date: Wed Jul 25 16:54:42 2018 Ensure all pref accesses are correct. All channels of Chrome should use the same preferences. This updates two preference accesses that were not updated in the original change. BUG= 866750 , 831577 Change-Id: Ibd0f8d2895027eb85772b3f5308ffebaef3aff32 Reviewed-on: https://chromium-review.googlesource.com/1148473 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577941} [modify] https://crrev.com/6fa568a41b3745d0876928c9352e541d1e015bd1/chrome/browser/policy/browser_dm_token_storage_mac.mm [modify] https://crrev.com/6fa568a41b3745d0876928c9352e541d1e015bd1/chrome/browser/policy/policy_path_parser_mac.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by a...@chromium.org
, Apr 11 2018Cc: pastarmovj@chromium.org grt@chromium.org blumberg@chromium.org georgesak@chromium.org atwilson@chromium.org
Components: Enterprise