New issue
Advanced search Search tips

Issue 831568 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

getComputedStyle shouldn't return a style for elements outside of the flattened tree.

Project Member Reported by emilio@chromium.org, Apr 11 2018

Issue description

Chrome Version: 65.0.3325.181 (Developer Build) Fedora Project (64-bit)
OS Version: Linux
Other browsers tested:
     Safari: FAIL
    Firefox: FAIL (though I'll fix that myself)
    IE/Edge: N/A (no Shadow DOM support).

See the tests at https://github.com/w3c/csswg-drafts/issues/1548, that tests the resolutions at https://github.com/w3c/csswg-drafts/issues/1548#issuecomment-380383455.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4953b70f39f00c5be23b84aade0084c025cc709b

commit 4953b70f39f00c5be23b84aade0084c025cc709b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Jul 23 20:42:28 2018

[Squad] Re-add null check for layout parent.

Because of issue 831568, we may end up trying to generate pseudo
elements for element outside the flat tree if we did a getComputedStyle
for all non-flat-tree ancestors and then triggered style invalidation of
the pseudo element's originating element.

This is not a new issue, but [1] boldly tried to make the if-test for a
layout parent a DCHECK. This CL is effectively reverting that change.

This should ultimately be fixed by fixing 831568 and re-introduce DCHECK
instead of the if-test.

[1] https://crrev.com/86f6eefc70ed2aa46969754e207198bd6917ee33

Bug:  862098 , 831568
Change-Id: Id10fdbe28592e492ef6903b82d2fc47bff930ea4
Reviewed-on: https://chromium-review.googlesource.com/1146729
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577245}
[modify] https://crrev.com/4953b70f39f00c5be23b84aade0084c025cc709b/third_party/blink/renderer/core/css/style_engine_test.cc
[modify] https://crrev.com/4953b70f39f00c5be23b84aade0084c025cc709b/third_party/blink/renderer/core/dom/element.cc

Sign in to add a comment