New issue
Advanced search Search tips

Issue 831566 link

Starred by 1 user
Status: Fixed
Owner:
dalecur...@chromium.org
Closed: Apr 2018
Cc:
rhalavati@chromium.org
mlamouri@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: ----



Sign in to add a comment

WebMediaPlayerImplTest.LoadPreloadMetadataSuspend flaky

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 11 2018 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of grunell@chromium.org

WebMediaPlayerImplTest.LoadPreloadMetadataSuspend in media_blink_unittests failing is flaky

Builders failed on: 
- Linux MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests
- Linux TSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests

On Msan, first seen in https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/9102

Failure:

[ RUN      ] WebMediaPlayerImplTest.LoadPreloadMetadataSuspend
../../media/blink/webmediaplayer_impl_unittest.cc:657: Failure
Mock function called more times than expected - returning directly.
    Function call: ReadyStateChanged()
         Expected: to be called once
           Actual: called twice - over-saturated and active
../../media/blink/webmediaplayer_impl_unittest.cc:663: Failure
Expected equality of these values:
  blink::WebMediaPlayer::kReadyStateHaveMetadata
    Which is: 1
  wmpi_->GetReadyState()
    Which is: 4
../../media/blink/webmediaplayer_impl_unittest.cc:666: Failure
Value of: wmpi_->seeking_
  Actual: false
Expected: true
[  FAILED  ] WebMediaPlayerImplTest.LoadPreloadMetadataSuspend (23 ms)

Comment 1 by grunell@chromium.org, Apr 11 2018

Cc: dalecur...@chromium.org mlamouri@chromium.org
Components: Internals>Media>Audio
Labels: OS-Linux
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8c9cb79a9736aa6dfd762a7aa3cccfd3c04a9d6

commit e8c9cb79a9736aa6dfd762a7aa3cccfd3c04a9d6
Author: Henrik Grunell <grunell@chromium.org>
Date: Wed Apr 11 13:44:11 2018

Disable flaky WebMediaPlayerImplTest.LoadPreloadMetadataSuspend on Linux MSan and TSan.

TBR=dalecurtis@chromium.org

Bug:  831566 
Change-Id: I3f553de7719c23f38a6fd707357dd406e1cb4928
Reviewed-on: https://chromium-review.googlesource.com/1007078
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549873}
[modify] https://crrev.com/e8c9cb79a9736aa6dfd762a7aa3cccfd3c04a9d6/media/blink/webmediaplayer_impl_unittest.cc

Comment 3 by dalecur...@chromium.org, Apr 11 2018

Cc: -dalecur...@chromium.org
Owner: dalecur...@chromium.org
Status: Assigned (was: Available)
Will take a look and fix tomorrow.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a98c719c8388a1bc07357b3113242c70e97fde5b

commit a98c719c8388a1bc07357b3113242c70e97fde5b
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Apr 13 03:46:06 2018

Fix flakiness in new WMPI::Load() tests.

Expecting readyStateChanged() to quit the message loop and do
nothing else appears to be unreliable due to us having configured
our ScopedTaskEnvironment for asynchronous execution. Switching to
a manually queued version would be painfully verbose given all the
happenings of the underlying demuxers and decoders; so instead
wait for loading to complete instead of quitting mid-way through
the loading process.

BUG= 831566 
TEST=tests don't flake under tsan.

Change-Id: If59ab647bb349bf996050545bb63b0e65cc471e2
Reviewed-on: https://chromium-review.googlesource.com/1011642
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550506}
[modify] https://crrev.com/a98c719c8388a1bc07357b3113242c70e97fde5b/media/blink/webmediaplayer_impl_unittest.cc

Comment 6 by rhalavati@chromium.org, Apr 13 2018

Cc: rhalavati@chromium.org
 Issue 832551  has been merged into this issue.

Comment 8 by rhalavati@chromium.org, Apr 13 2018

Labels: -Sheriff-Chromium
Disabling the test: crrev.com/c/1011612

Comment 9 by grunell@chromium.org, Apr 13 2018

Cc: -grunell@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95989cb55f0f86b5961834c0dcb048f816510b9b

commit 95989cb55f0f86b5961834c0dcb048f816510b9b
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 13 08:30:42 2018

Disable flaky test WebMediaPlayerImplTest.LoadPreloadMetadataSuspend.

Bug:  831566 
Change-Id: I020d3829eeeb4fff098efaf751465fdc21e9edb4
TBR: chcunningham@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1011612
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550547}
[modify] https://crrev.com/95989cb55f0f86b5961834c0dcb048f816510b9b/media/blink/webmediaplayer_impl_unittest.cc

Comment 11 by dalecur...@chromium.org, Apr 13 2018 

Ah, just needs an WillRepeatedly vs WillOnce.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c039aa885524b093f351c33acd3170b57d4feee3

commit c039aa885524b093f351c33acd3170b57d4feee3
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Apr 13 19:24:38 2018

Flakiness fix attempt #2 for WMPI::Load() tests.

Use WillRepeatedly() instead of WillOnce().

BUG= 831566 
TBR=chcunningham

Change-Id: I2cebaebcfa5ff026c43d3c4a267f5d3653e91dae
Reviewed-on: https://chromium-review.googlesource.com/1012699
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550717}
[modify] https://crrev.com/c039aa885524b093f351c33acd3170b57d4feee3/media/blink/webmediaplayer_impl_unittest.cc

Comment 13 by dalecur...@chromium.org, Apr 13 2018

Status: Fixed (was: Assigned)
Hopefully all fixed now.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a98c719c8388a1bc07357b3113242c70e97fde5b

commit a98c719c8388a1bc07357b3113242c70e97fde5b
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Apr 13 03:46:06 2018

Fix flakiness in new WMPI::Load() tests.

Expecting readyStateChanged() to quit the message loop and do
nothing else appears to be unreliable due to us having configured
our ScopedTaskEnvironment for asynchronous execution. Switching to
a manually queued version would be painfully verbose given all the
happenings of the underlying demuxers and decoders; so instead
wait for loading to complete instead of quitting mid-way through
the loading process.

BUG= 831566 
TEST=tests don't flake under tsan.

Change-Id: If59ab647bb349bf996050545bb63b0e65cc471e2
Reviewed-on: https://chromium-review.googlesource.com/1011642
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550506}
[modify] https://crrev.com/a98c719c8388a1bc07357b3113242c70e97fde5b/media/blink/webmediaplayer_impl_unittest.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95989cb55f0f86b5961834c0dcb048f816510b9b

commit 95989cb55f0f86b5961834c0dcb048f816510b9b
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 13 08:30:42 2018

Disable flaky test WebMediaPlayerImplTest.LoadPreloadMetadataSuspend.

Bug:  831566 
Change-Id: I020d3829eeeb4fff098efaf751465fdc21e9edb4
TBR: chcunningham@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1011612
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550547}
[modify] https://crrev.com/95989cb55f0f86b5961834c0dcb048f816510b9b/media/blink/webmediaplayer_impl_unittest.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c039aa885524b093f351c33acd3170b57d4feee3

commit c039aa885524b093f351c33acd3170b57d4feee3
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Apr 13 19:24:38 2018

Flakiness fix attempt #2 for WMPI::Load() tests.

Use WillRepeatedly() instead of WillOnce().

BUG= 831566 
TBR=chcunningham

Change-Id: I2cebaebcfa5ff026c43d3c4a267f5d3653e91dae
Reviewed-on: https://chromium-review.googlesource.com/1012699
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550717}
[modify] https://crrev.com/c039aa885524b093f351c33acd3170b57d4feee3/media/blink/webmediaplayer_impl_unittest.cc

Comment 17 by anatolid@chromium.org, Jun 7 2018 

[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
►

Sign in to add a comment