New issue
Advanced search Search tips

Issue 831563 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Flaky-Test: NotificationImageReporterTest.NoReportWithoutReportingEnabled

Blocked on:
issue 837707



Sign in to add a comment

NotificationImageReporterTest.NoReportWithoutReportingEnabled is Flaky

Project Member Reported by Findit, Apr 11 2018

Issue description

Findit has detected a flake at test NotificationImageReporterTest.NoReportWithoutReportingEnabled.

Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/Ib41699d932469b4bb92130103b5257509d6b2a36
Regression range: None

Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKGAWNocm9taXVtLm1lbW9yeS9MaW51eCBUU2FuIFRlc3RzLzIwMTA3L3VuaXRfdGVzdHMvVG05MGFXWnBZMkYwYVc5dVNXMWhaMlZTWlhCdmNuUmxjbFJsYzNRdVRtOVNaWEJ2Y25SWGFYUm9iM1YwVW1Wd2IzSjBhVzVuUlc1aFlteGxaQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
 
Project Member

Comment 1 by Findit, Apr 11 2018

Findit identified the culprit r549677 with confidence 70.0% in the config "chromium.memory / Linux TSan Tests"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKGAWNocm9taXVtLm1lbW9yeS9MaW51eCBUU2FuIFRlc3RzLzIwMTA3L3VuaXRfdGVzdHMvVG05MGFXWnBZMkYwYVc5dVNXMWhaMlZTWlhCdmNuUmxjbFJsYzNRdVRtOVNaWEJ2Y25SWGFYUm9iM1YwVW1Wd2IzSjBhVzVuUlc1aFlteGxaQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Owner: jam@chromium.org
Status: Assigned (was: Available)
Will disable test.
Cc: mstensho@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45957792a1205b5f6c676c648518c75c934614e9

commit 45957792a1205b5f6c676c648518c75c934614e9
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Thu Apr 19 15:07:15 2018

Disable flaky NotificationImageReporterTest.NoReportWithoutReportingEnabled

Also fixed a bogus explicit constructor with no parameters, because
presubmit complained.

TBR=jam@chromium.org

Bug:  831563 
Change-Id: I2d43b57cc1cb67c508fd9475f78f58a36720f06b
Reviewed-on: https://chromium-review.googlesource.com/1019444
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552018}
[modify] https://crrev.com/45957792a1205b5f6c676c648518c75c934614e9/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc

Labels: -Sheriff-Chromium
Components: UI>Browser>SafeBrowsing
Cc: jam@chromium.org
Labels: SafeBrowsing-Triaged
Owner: vakh@chromium.org
vakh will be removing this feature altogether.

Comment 9 by vakh@chromium.org, May 4 2018

Blockedon: 837707
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d38b38428a8060ce1a2644a364b1466060d50aab

commit d38b38428a8060ce1a2644a364b1466060d50aab
Author: Varun Khaneja <vakh@chromium.org>
Date: Wed Jul 18 19:53:49 2018

Remove NotificationImageReporter since it the backend support is not planned

R=nparker

Bug: 837707, 836359 , 831563 
Change-Id: Ice5c619948e47a3df6a257fc062ab9d38928bbab
Reviewed-on: https://chromium-review.googlesource.com/1139032
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576175}
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/android_webview/browser/aw_safe_browsing_ui_manager.cc
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/android_webview/browser/aw_safe_browsing_ui_manager.h
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/chrome/browser/safe_browsing/BUILD.gn
[delete] https://crrev.com/28ae7e13cf5b8ac2e51ccaed9c342934ff3a39e6/chrome/browser/safe_browsing/notification_image_reporter.cc
[delete] https://crrev.com/28ae7e13cf5b8ac2e51ccaed9c342934ff3a39e6/chrome/browser/safe_browsing/notification_image_reporter.h
[delete] https://crrev.com/28ae7e13cf5b8ac2e51ccaed9c342934ff3a39e6/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[delete] https://crrev.com/28ae7e13cf5b8ac2e51ccaed9c342934ff3a39e6/chrome/browser/safe_browsing/ping_manager.cc
[delete] https://crrev.com/28ae7e13cf5b8ac2e51ccaed9c342934ff3a39e6/chrome/browser/safe_browsing/ping_manager.h
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/chrome/browser/safe_browsing/test_safe_browsing_service.cc
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/chrome/browser/safe_browsing/ui_manager.cc
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/chrome/test/BUILD.gn
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/components/safe_browsing/BUILD.gn
[rename] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/components/safe_browsing/ping_manager.cc
[rename] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/components/safe_browsing/ping_manager.h
[rename] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/components/safe_browsing/ping_manager_unittest.cc
[modify] https://crrev.com/d38b38428a8060ce1a2644a364b1466060d50aab/tools/traffic_annotation/summary/annotations.xml

Status: Fixed (was: Assigned)

Sign in to add a comment