Regression: Extension icon is not seen in wrench menu after dragging it from chrome toolbar.
Reported by
db...@etouch.net,
Apr 11 2018
|
|||||||
Issue descriptionChrome Version: 67.0.3393.4 (Official Build) Revision 1c8c7bb130996ac73fdf93473d13849dbcba5240-refs/branch-heads/3393@{#6} (32/64 Bit) OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS). URL: https://chrome.google.com/webstore/detail/honey/bmnlcjabgnpnenekpadlanbbkooimhnj/related?hl=en-GB What steps will reproduce the problem? (1) Launch chrome, navigate to above URL and click on ADD TO CHROME button. (2) Navigate to any PDF file (e.g. http://www.orimi.com/pdf-test.pdf),drag extension icon from chrome toolbar to wrench menu (3) Then click on extension icon (extension url opened), now click on wrench icon and observe. Actual: Extension icon is not seen in wrench menu. Expected: Extension icon should seen in wrench menu. This is a regression issue broken in ‘M-67’ and using per-revision bisect providing the bisect results, Good Build:67.0.3378.0(Revision: 544932) Bad Build:67.0.3379.0(Revision: 545319) You are probably looking for a change made after 544962 (known good), but no later than 544963 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/fae199abc147d925470e745e0fa2752775d4fa63..bd465948ea74fbf1d40c495832e4306c07c13406 Suspect:https://chromium.googlesource.com/chromium/src/+/bd465948ea74fbf1d40c495832e4306c07c13406 @Ahmed Fakhry: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d26eda6c885bdfe90465742361a2f23c39919d4 commit 1d26eda6c885bdfe90465742361a2f23c39919d4 Author: Ahmed Fakhry <afakhry@google.com> Date: Fri Apr 13 17:04:40 2018 Fix getting BrowserActionsContainer target width when animating The target width can be set to zero when the action bar has no icons. Zero in this case is a valid target width that should be used instead of the current width when animating. BUG= 831560 Change-Id: Ib6604a9c56a6b922025cd3d3bce2773f78d3eda4 Reviewed-on: https://chromium-review.googlesource.com/1008871 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550658} [modify] https://crrev.com/1d26eda6c885bdfe90465742361a2f23c39919d4/chrome/browser/ui/views/toolbar/browser_actions_container.cc
,
Apr 13 2018
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d26eda6c885bdfe90465742361a2f23c39919d4 commit 1d26eda6c885bdfe90465742361a2f23c39919d4 Author: Ahmed Fakhry <afakhry@google.com> Date: Fri Apr 13 17:04:40 2018 Fix getting BrowserActionsContainer target width when animating The target width can be set to zero when the action bar has no icons. Zero in this case is a valid target width that should be used instead of the current width when animating. BUG= 831560 Change-Id: Ib6604a9c56a6b922025cd3d3bce2773f78d3eda4 Reviewed-on: https://chromium-review.googlesource.com/1008871 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550658} [modify] https://crrev.com/1d26eda6c885bdfe90465742361a2f23c39919d4/chrome/browser/ui/views/toolbar/browser_actions_container.cc
,
Apr 18 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2018
Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Dev/Beta release. If already merged to M67 and nothing is pending, pls remove "Merge=Approved-67" label. Thank you.
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fedc54efe060e94c400108ec60acb18fc9a1ca0f commit fedc54efe060e94c400108ec60acb18fc9a1ca0f Author: Ahmed Fakhry <afakhry@google.com> Date: Wed Apr 18 20:33:54 2018 [Merge to M-67] Fix getting BrowserActionsContainer target width when animating The target width can be set to zero when the action bar has no icons. Zero in this case is a valid target width that should be used instead of the current width when animating. TBR=pkasting@chromium.org, bsep@chromium.org, pbos@chromium.org BUG= 831560 (cherry picked from commit 1d26eda6c885bdfe90465742361a2f23c39919d4) Change-Id: Ib6604a9c56a6b922025cd3d3bce2773f78d3eda4 Reviewed-on: https://chromium-review.googlesource.com/1008871 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550658} Reviewed-on: https://chromium-review.googlesource.com/1017779 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#101} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/fedc54efe060e94c400108ec60acb18fc9a1ca0f/chrome/browser/ui/views/toolbar/browser_actions_container.cc
,
Apr 24 2018
Update : Retested above issue in latest Dev build #67.0.3396.18 on Windows(7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.13.5) & Linux(14.04 LTS) OS and the issue is fixed. Kindly review an attached screen-cast. Thank you..! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by afakhry@chromium.org
, Apr 11 2018Status: Started (was: Assigned)