Issue metadata
Sign in to add a comment
|
Scrolling up new tab page doesn’t move the omnibox all the way to the top of the screen |
||||||||||||||||||||||
Issue descriptionApp Version: 67.0.3394.0 Canary iOS Version: 10.3.3 only Device: iPhone only Steps to reproduce: 1. Launch chrome 2. Let the content suggestions load completely 3. Scroll the new tab page Observed results: Notice that omnibox is not scrolling all the way to the top of screen Expected results: Omnibox should be scrolled to the top of the new tab page Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M65 Bug reproducible on the current beta channel build (App Version, iOS Version): No on M66 Link to video: https://drive.google.com/file/d/1uqOx8xYbbOwYS0rpxAg1nik7vPdLCJhx/view?usp=sharing
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af5067d1079b79bb537f2c5ac388472862ebe08a commit af5067d1079b79bb537f2c5ac388472862ebe08a Author: Justin Cohen <justincohen@google.com> Date: Wed Apr 11 19:42:00 2018 [ios] Fix NTP scrolled omnibox for iOS10. This was broken by crrev.com/548047, which should have been wrapped in a ui refresh flag. Bug: 819460 , 831555 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b081548de5f058a81530d9dd20f369e2e1fca7d Reviewed-on: https://chromium-review.googlesource.com/1008044 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549942} [modify] https://crrev.com/af5067d1079b79bb537f2c5ac388472862ebe08a/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
,
Apr 12 2018
,
Apr 12 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
,
Apr 13 2018
549942 < 550428 (M67), removing Mere Merge-TBD
,
Apr 17 2018
Verified in: App Version: 68.0.3398.0 canary Devices: iPhone 7, iPhone 6S Plus iOS Version: 10.3.3 Able to scroll omnibox to top of the NTP. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sczs@chromium.org
, Apr 11 2018Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)