New issue
Advanced search Search tips

Issue 831544 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CSSStyleDeclaration: CSS property attributes should use [TreatNullAs=EmptyString]

Project Member Reported by raphael....@intel.com, Apr 11 2018

Issue description

https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-camel-cased-attribute, https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-dashed-attribute and https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-_webkit_cased_attribute all define their "pseudo-attributes" like this:

    partial interface CSSStyleDeclaration {
      [CEReactions] attribute [TreatNullAs=EmptyString] CSSOMString _dashed_attribute;
    };

Blink currently uses anonymous property getters/setters to handle these (see bug 700338) with a different value for the [TreatNullAs] extended attribute:

    [CEReactions, CallWith=ScriptState, RaisesException] setter void (DOMString property, [TreatNullAs=NullString] DOMString propertyValue);

We should use [TreatNullAs=EmptyString] instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dd9a1afa4f95e9625b6b68ea9217f0f2511dbd1

commit 7dd9a1afa4f95e9625b6b68ea9217f0f2511dbd1
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Wed Oct 03 06:45:21 2018

Remove [TreatNullAs=NullString] in CSSStyleDeclaration

Replace NullString with EmptyString since [TreatNullAs=NullString] is
deprecated.

This CL has no behavior changes.

Bug: 497307,  831544 
Change-Id: I4ae886b3f3b1159f67b9897e2e0f4f0423477f7f
Reviewed-on: https://chromium-review.googlesource.com/c/1175589
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#596134}
[modify] https://crrev.com/7dd9a1afa4f95e9625b6b68ea9217f0f2511dbd1/third_party/blink/renderer/core/css/css_style_declaration.idl

Status: Fixed (was: Available)

Sign in to add a comment