New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831527 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : 'Close' Tool tip is seen missing on hovering mouse pointer on close Icon at 'Learn more' overlay

Project Member Reported by mmanchala@chromium.org, Apr 11 2018

Issue description

Chrome Version: 66.0.3359.94/10452.54.0 beta-channel Daisy,Kip and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into user -> Open Play store 
(2)In 'Google Play Terms of Service' page -> Click on  'Learn more' link -> In Learn More overlay hover mouse on 'Close' icon and observe for tool tip
(Please refer video)

Note : 
1.Sign into User -> Click on 'ACCEPT AND CONTINUE" button -> now'Google Play Terms of Service' page is seen ->  hover mouse on 'Close' icon and observe for tool tip
(Please refer 'Actual_NoTooltipForCloseIconInLEarnMoreoverlayAtSyncSettingsScreen' video and screenshot)
2.Issue is seen in all Learn more overlays

Expected: 'Close' tool tip should be seen on hovering mouse pointer at 'Close' icon in 'Learn more' overlay
Actual: Instead No tool tip is seen

This is Non-Regression issue seen from M-62

@khmel : Please confirm the issue
 
Actual_NoCloseTooltipInSignInScreenPlayStoreScreen.mp4
9.6 MB View Download
Actual_NoCloseTooltip.jpg
612 KB View Download
Expected_CloseTooltip.jpg
530 KB View Download
Note:
3. Issue is also seen in M-65 and on latest M-67


Actual_NoTooltipForCloseIconInLEarnMoreoverlayAtSyncSettingsScreen.mp4
14.2 MB View Download

Comment 2 by khmel@chromium.org, Apr 19 2018

Cc: lgcheng@google.com
Labels: -Pri-2 Pri-3
Owner: elijahtaylor@chromium.org
Not sure if we want tooltip here. Checked many dialogs and no tooltip there.

Cc: -lgcheng@google.com shihuis@chromium.org elijahtaylor@chromium.org khmel@chromium.org
Labels: -Pri-3 -M-66 M-68 Pri-2
Owner: lgcheng@google.com
> Not sure if we want tooltip here.

We almost certainly do.  I'm assuming this is an a11y issue if nothing else.

> Checked many dialogs and no tooltip there.

IMO we should fix the other ones too.  +1000 if we can somehow fix this systemically for all such buttons in one go instead of playing whack-a-mole

Comment 4 by lgcheng@google.com, Apr 19 2018

Cc: -shihuis@chromium.org shihuis@google.com

Comment 5 by khmel@chromium.org, May 17 2018

Owner: khmel@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91c230c66f349536e58e315ac9604311cee7dcd9

commit 91c230c66f349536e58e315ac9604311cee7dcd9
Author: khmel@google.com <khmel@google.com>
Date: Fri May 18 17:42:24 2018

arc: Unify help overlay view in OOBE with in-session UI.

This adds close button and limit focus traversal inside overlay for OOBE
Optin. Adds tooltip for close button for both UI. Adds screen 'loading'
for webview based help for both UI

Test: Manually
Bug:  837597 
Bug:  836197 
Bug:  836195 
Bug:  831527 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I63bae1200e3573a06f63bdd7e12f34a46a9e5d84
Reviewed-on: https://chromium-review.googlesource.com/1065139
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559942}
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/login/arc_terms_of_service.js
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.css
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.html
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
[modify] https://crrev.com/91c230c66f349536e58e315ac9604311cee7dcd9/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc

Comment 7 by khmel@chromium.org, May 18 2018

Status: Fix (was: Assigned)

Comment 8 by khmel@chromium.org, May 18 2018

Status: Fixed (was: Fix)

Sign in to add a comment