Enable Zip Archiver for packing on MTP volumes |
|||||||
Issue descriptionChrome Version: 67.0.3393.0 Steps To Reproduce: (1) Connect an Android phone to a Chromebook device by USB. Switch the USB connection option of the phone to MTP mode. (2) Open a folder of the MTP volume in the Files app (or DCIM folder will automatically open) (3) Right-click one of the files. Expected Result: "Zip selection" context menu item is available. It will create a ZIP file there. Actual Result: The menu item is grayed out. Note: When the #zip-archiver-packer is set to Disabled, the menu item should be kept grayed out.
,
Apr 11 2018
,
Apr 11 2018
Note: The item has been disabled because the older ZIP packing implementation didn't work on MTP volumes. ( Issue 486397 )
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee00582187dffd8a1de773661061aea2af8bbc14 commit ee00582187dffd8a1de773661061aea2af8bbc14 Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Mon Apr 16 01:55:22 2018 Allow running Zip Archiver for packing on MTP volumes. The feature was disabled on MTP volumes because older implementaiton didn't work on MTP volumes (crbug/486397). The packing function of Zip Archiver works on MTP volumes. Bug: 831525 Test: Manually tested by zipping file on a connected MTP device. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I61830c5853e7290295ed01f4cfe439f68dfb2480 Reviewed-on: https://chromium-review.googlesource.com/1006741 Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550921} [modify] https://crrev.com/ee00582187dffd8a1de773661061aea2af8bbc14/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
,
Apr 16 2018
,
Apr 16 2018
Merge approved for M67 Chrome OS
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c9a7b70b811f79d8f14676a2be692c71a058581 commit 0c9a7b70b811f79d8f14676a2be692c71a058581 Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Mon Apr 16 22:51:17 2018 Allow running Zip Archiver for packing on MTP volumes. The feature was disabled on MTP volumes because older implementaiton didn't work on MTP volumes (crbug/486397). The packing function of Zip Archiver works on MTP volumes. Bug: 831525 Test: Manually tested by zipping file on a connected MTP device. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I61830c5853e7290295ed01f4cfe439f68dfb2480 Reviewed-on: https://chromium-review.googlesource.com/1006741 Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550921}(cherry picked from commit ee00582187dffd8a1de773661061aea2af8bbc14) Reviewed-on: https://chromium-review.googlesource.com/1013961 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#30} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/0c9a7b70b811f79d8f14676a2be692c71a058581/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee00582187dffd8a1de773661061aea2af8bbc14 commit ee00582187dffd8a1de773661061aea2af8bbc14 Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Mon Apr 16 01:55:22 2018 Allow running Zip Archiver for packing on MTP volumes. The feature was disabled on MTP volumes because older implementaiton didn't work on MTP volumes (crbug/486397). The packing function of Zip Archiver works on MTP volumes. Bug: 831525 Test: Manually tested by zipping file on a connected MTP device. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I61830c5853e7290295ed01f4cfe439f68dfb2480 Reviewed-on: https://chromium-review.googlesource.com/1006741 Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550921} [modify] https://crrev.com/ee00582187dffd8a1de773661061aea2af8bbc14/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
,
Apr 18 2018
To be confirmed on M67 release branch. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yamaguchi@chromium.org
, Apr 11 2018