Touch events is filtered in draggable area of floating keyboard |
||
Issue descriptionChrome Version: 67.0.3390.0 OS: ChromeOS What steps will reproduce the problem? (1) First log in, then open chrome://flags, enable virtual keyboard and floating keyboard. (2) Log out, in login screen, switch keyboard to floating mode. (3) Tap on number key, can't input the digital number. Other problem. 1. Click "..." to pop up IME selection menu. 2. Can't tap the first item on menu which cover on draggable area.
,
Apr 11 2018
Since the bug is more serve than flickering issue. I will rollback that CL which filter pointer events on draggable area.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35a5292481c4932de395906242f491f46baed743 commit 35a5292481c4932de395906242f491f46baed743 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Wed Apr 11 12:04:57 2018 Revert "Floating Keyboard stops propagation of drag handle events" This reverts commit 6b3d6841cf0897f2824c799098d6c24eaa0ac679. Reason for revert: Please refer to crbug.com/831521 . We need to pass tap events in the drag handle. Original change's description: > Floating Keyboard stops propagation of drag handle events > > If a touch/mouse event occurs and it is interpreted as a floating > keyboard drag event, do not propagate the event to the javascript > keyboard extension as there is no reason to. > > This was causing the drag event to cause the gesture swiping to be > active while dragging the keyboard around, particularly if the keyboard > was bounded to the bottom of the screen and the user's finger is able > to move around on the keys while still moving the keyboard (see > attached bug for repro/video). > > Bug: 826078 > Change-Id: I40c859f979d41a5d61e88ff0bd41808dcf3940c2 > Reviewed-on: https://chromium-review.googlesource.com/997195 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Blake O'Hare <blakeo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548374} TBR=yhanada@chromium.org,blakeo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826078 Bug: 831521 Change-Id: I9dded92a6e7b2ec1f97ebd169c463686c23d5d7c Reviewed-on: https://chromium-review.googlesource.com/1006715 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#549862} [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_behavior.h [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_floating_behavior.cc [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_floating_behavior.h [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/container_full_width_behavior.h [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/keyboard_event_filter.cc [modify] https://crrev.com/35a5292481c4932de395906242f491f46baed743/ui/keyboard/keyboard_event_filter.h
,
Apr 24 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by wuyingbing@chromium.org
, Apr 11 201842.2 KB
42.2 KB View Download