Blur effect not displayed on toolbar |
||||
Issue descriptionEnable UI refresh flag. What steps will reproduce the problem? (1) Open a new tab (2) Navigate to a page (e.g. wikipedia.org) (3) Navigate back to the NTP (4) Navigate forward to the page What is the expected result? The toolbar should blur the page displayed below it. What happens instead? The toolbar is solid grey.
,
Apr 11 2018
I think CRWWebViewScrollViewProxy should persists clipsToBounds property. ios/chrome layer should not care about web view destructions. Can we update -[CRWWebViewScrollViewProxy setScrollView:] to update clipsToBounds every time when web view is recreated?
,
Apr 11 2018
Sure, we currently reset the property after setting it for the first time. I introduced this behavior because it is what we are doing for all the other properties of CRWWebViewScrollViewProxy. Should the other properties behavior in the same way (i.e. not reset after being set)?
,
Apr 11 2018
For consistency reason it would be better if other properties do not reset after being set.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fe307159eea27de82c37e8898d875bd4e4ceab6 commit 5fe307159eea27de82c37e8898d875bd4e4ceab6 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Apr 17 07:28:43 2018 Persit the property values of the WebViewScroll This CL changes the CRWWebViewScrollViewProxy such as it is now persisting the value of the properties even after setting a new ScrollView. Bug: 831519 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I776c7983df536d5bed9c03a826998413b8a6d246 Reviewed-on: https://chromium-review.googlesource.com/1013520 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551271} [modify] https://crrev.com/5fe307159eea27de82c37e8898d875bd4e4ceab6/ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm [modify] https://crrev.com/5fe307159eea27de82c37e8898d875bd4e4ceab6/ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm
,
Apr 17 2018
,
Apr 17 2018
,
Apr 24 2018
Verified in 68.0.3405.0 Canary in iPhone 8plus(iOS 11.2.6) and iPhone 7plus(iOS 10.3.3) Followed the steps in comment #0. The issue is now resolved blur effect is displayed in toolbar
,
Apr 25 2018
The NextAction date has arrived: 2018-04-25
,
Apr 25 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by gambard@chromium.org
, Apr 11 2018