New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 831516 link

Starred by 1 user
Status: Fixed
Owner:
bsazonov@chromium.org
Closed: Apr 2018
Cc:
twelling...@chromium.org
tedc...@chromium.org
█ bauerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Interpolators use non-default resource folder

Project Member Reported by bsazonov@chromium.org, Apr 11 2018 
According to the documentation, custom interpolators are supposed to be in res/anim/ folder ([1], search for "Custom interpolators"). However, currently Chrome keeps two files with custom interpolators in res/interpolator/ folder [2].

It works as expected, but produces annoying errors in AndroidStudio (see screenshot).

I don't see any drawbacks from moving these interpolators to res/anim/ folder.

[1] https://developer.android.com/guide/topics/resources/animation-resource.html
[2] https://cs.chromium.org/chromium/src/chrome/android/java/res/interpolator/
Screenshot from 2018-04-10 09-44-59.png
22.7 KB View Download

Comment 1 by bsazonov@chromium.org, Apr 20 2018 

On the second thought - it looks like we can use interpolators from Android resources in both these cases, so there's no need to have custom ones at all.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c48712bbd648d5f29716371d5154c775ad80e81

commit 5c48712bbd648d5f29716371d5154c775ad80e81
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Fri Apr 20 15:13:13 2018

[Android] Replace custom interpolators with standard ones from Android

This CL removes interpolators from the custom res/interpolators folder,
replacing usages with references to the identical interpolators in
Android resources.

Bug:  831516 
Change-Id: I863bc87d0e956117c78924a2843b952f7f7e1d22
Reviewed-on: https://chromium-review.googlesource.com/1019780
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552335}
[modify] https://crrev.com/5c48712bbd648d5f29716371d5154c775ad80e81/chrome/android/java/res/anim/menu_enter.xml
[modify] https://crrev.com/5c48712bbd648d5f29716371d5154c775ad80e81/chrome/android/java/res/anim/menu_enter_from_bottom.xml
[modify] https://crrev.com/5c48712bbd648d5f29716371d5154c775ad80e81/chrome/android/java/res/anim/menu_exit.xml
[modify] https://crrev.com/5c48712bbd648d5f29716371d5154c775ad80e81/chrome/android/java/res/anim/menu_exit_from_bottom.xml
[delete] https://crrev.com/8199ce08fa50c16d4468c04b0e2fc4bed4d42477/chrome/android/java/res/interpolator/fade_out_curve_interpolator.xml
[delete] https://crrev.com/8199ce08fa50c16d4468c04b0e2fc4bed4d42477/chrome/android/java/res/interpolator/transform_curve_interpolator.xml

Comment 3 by bsazonov@chromium.org, Apr 20 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment