New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 831514 link

Starred by 2 users
Status: Fixed
Owner:
chfremer@chromium.org
Closed: Aug 3
Cc:
niklase@chromium.org
emir...@chromium.org
█ phoglund@chromium.org
chfremer@chromium.org
jansson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 828568


Sign in to add a comment

VideoCaptureDeviceTests are flaky on Linux

Project Member Reported by phoglund@chromium.org, Apr 11 2018 
https://build.chromium.org/deprecated/chromium.webrtc/builders/Linux%20Tester/builds/37284:

Failures generally look like this:

VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureMjpeg/0 (run #1):
[ RUN      ] VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureMjpeg/0
../../media/capture/video/video_capture_device_unittest.cc:617: Failure
Mock function called more times than expected - taking default action specified at:
../../media/capture/video/video_capture_device_unittest.cc:157:
    Function call: OnError(@0x7fba55c08770 32-byte object <EE-63 20-00 00-00 00-00 00-59 21-00 00-00 00-00 F7-01 00-00 9F-18 00-00 95-0A 6A-00 00-00 00-00>, @0x7fba55c08750 "VIDIOC_STREAMON failed")
         Expected: to be never called
           Actual: called once - over-saturated and active
VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureMjpeg/0 (run #2):
[ RUN      ] VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureMjpeg/0
../../media/capture/video/video_capture_device_unittest.cc:617: Failure
Mock function called more times than expected - taking default action specified at:
../../media/capture/video/video_capture_device_unittest.cc:157:
    Function call: OnError(@0x7f74fa4ae770 32-byte object <EE-63 20-00 00-00 00-00 00-59 21-00 00-00 00-00 F7-01 00-00 4F-0F 00-00 95-0A 6A-00 00-00 00-00>, @0x7f74fa4ae750 "VIDIOC_STREAMON failed")
         Expected: to be never called
           Actual: called once - over-saturated and active

Comment 1 by phoglund@chromium.org, Apr 11 2018

Labels: Test-Flaky

Comment 2 by phoglund@chromium.org, Apr 11 2018

Cc: niklase@chromium.org chfremer@chromium.org

Comment 3 by phoglund@chromium.org, Apr 11 2018 

Actually, this is probably an infra problem. We swapped out this bot recently.

I'll see if we can resolve the infra problem; otherwise I have a patch to disable the tests.

Comment 4 by phoglund@chromium.org, Apr 17 2018

Cc: jansson@chromium.org emir...@chromium.org phoglund@chromium.org
 Issue 833541  has been merged into this issue.

Comment 5 by phoglund@chromium.org, Apr 17 2018

Blockedon: 828568

Comment 6 by emir...@chromium.org, Apr 19 2018 

This is causing 10+ flakes daily. Lets land the test to fix that.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46bf6346e6dc1d51ba998524a88e1a38e409a1ad

commit 46bf6346e6dc1d51ba998524a88e1a38e409a1ad
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Apr 19 21:34:26 2018

Disable flaky capture unittests on Linux.

The tests went flaky when we replaced the bot and get VIDIOC_STREAMON
errors about 25% of the builds. I have no idea to fix that; we tried
replacing the webcam and moving it around in the USB ports and that
didn't help. See http://crbug.com/828568 for discussion.

Bug:  chromium:831514 
Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9
Reviewed-on: https://chromium-review.googlesource.com/1016301
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552165}
[modify] https://crrev.com/46bf6346e6dc1d51ba998524a88e1a38e409a1ad/media/capture/video/video_capture_device_unittest.cc

Comment 8 by yini...@chromium.org, Apr 27 2018

Status: Available (was: Untriaged)
whoever own these tests please take this bug.

Comment 9 by emir...@chromium.org, Apr 27 2018

Owner: chfremer@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a99efe4b25a3f2e0a05c33e05edabb3034f22afd

commit a99efe4b25a3f2e0a05c33e05edabb3034f22afd
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed May 02 10:46:23 2018

Revert "Disable flaky capture unittests on Linux."

This reverts commit 46bf6346e6dc1d51ba998524a88e1a38e409a1ad.

Reason for revert: New webcam plugged in; let's see if they're still flaky.

Original change's description:
> Disable flaky capture unittests on Linux.
> 
> The tests went flaky when we replaced the bot and get VIDIOC_STREAMON
> errors about 25% of the builds. I have no idea to fix that; we tried
> replacing the webcam and moving it around in the USB ports and that
> didn't help. See http://crbug.com/828568 for discussion.
> 
> Bug:  chromium:831514 
> Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9
> Reviewed-on: https://chromium-review.googlesource.com/1016301
> Reviewed-by: Christian Fremerey <chfremer@chromium.org>
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552165}

TBR=phoglund@chromium.org,chfremer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:831514 , chromium:828568
Change-Id: I01b21c5073e79e004c74430cc6eeb3422b602745
Reviewed-on: https://chromium-review.googlesource.com/1039425
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555342}
[modify] https://crrev.com/a99efe4b25a3f2e0a05c33e05edabb3034f22afd/media/capture/video/video_capture_device_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee35ff8f80a9d6e26af550ba731418dff3a76976

commit ee35ff8f80a9d6e26af550ba731418dff3a76976
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri May 04 06:01:05 2018

Reland "Disable flaky capture unittests on Linux."

This reverts commit a99efe4b25a3f2e0a05c33e05edabb3034f22afd.

Reason for revert: Still flaky.

Original change's description:
> Revert "Disable flaky capture unittests on Linux."
> 
> This reverts commit 46bf6346e6dc1d51ba998524a88e1a38e409a1ad.
> 
> Reason for revert: New webcam plugged in; let's see if they're still flaky.
> 
> Original change's description:
> > Disable flaky capture unittests on Linux.
> > 
> > The tests went flaky when we replaced the bot and get VIDIOC_STREAMON
> > errors about 25% of the builds. I have no idea to fix that; we tried
> > replacing the webcam and moving it around in the USB ports and that
> > didn't help. See http://crbug.com/828568 for discussion.
> > 
> > Bug:  chromium:831514 
> > Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9
> > Reviewed-on: https://chromium-review.googlesource.com/1016301
> > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
> > Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#552165}
> 
> TBR=phoglund@chromium.org,chfremer@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  chromium:831514 , chromium:828568
> Change-Id: I01b21c5073e79e004c74430cc6eeb3422b602745
> Reviewed-on: https://chromium-review.googlesource.com/1039425
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555342}

TBR=phoglund@chromium.org,chfremer@chromium.org

Change-Id: I9c976f8bb2e0812029d13ae020896bebadf4ef1c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:831514 , chromium:828568
Reviewed-on: https://chromium-review.googlesource.com/1041945
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555996}
[modify] https://crrev.com/ee35ff8f80a9d6e26af550ba731418dff3a76976/media/capture/video/video_capture_device_unittest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/191d55580e6b2dda1206b51de589e18e7865b863

commit 191d55580e6b2dda1206b51de589e18e7865b863
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri May 11 09:36:19 2018

Revert "Disable flaky capture unittests on Linux."

This reverts commit ee35ff8f80a9d6e26af550ba731418dff3a76976.

Reason for revert: New USB card in place, let's see if still flaky

Original change's description:
> Reland "Disable flaky capture unittests on Linux."
> 
> This reverts commit a99efe4b25a3f2e0a05c33e05edabb3034f22afd.
> 
> Reason for revert: Still flaky.
> 
> Original change's description:
> > Revert "Disable flaky capture unittests on Linux."
> > 
> > This reverts commit 46bf6346e6dc1d51ba998524a88e1a38e409a1ad.
> > 
> > Reason for revert: New webcam plugged in; let's see if they're still flaky.
> > 
> > Original change's description:
> > > Disable flaky capture unittests on Linux.
> > > 
> > > The tests went flaky when we replaced the bot and get VIDIOC_STREAMON
> > > errors about 25% of the builds. I have no idea to fix that; we tried
> > > replacing the webcam and moving it around in the USB ports and that
> > > didn't help. See http://crbug.com/828568 for discussion.
> > > 
> > > Bug:  chromium:831514 
> > > Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9
> > > Reviewed-on: https://chromium-review.googlesource.com/1016301
> > > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
> > > Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#552165}
> > 
> > TBR=phoglund@chromium.org,chfremer@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug:  chromium:831514 , chromium:828568
> > Change-Id: I01b21c5073e79e004c74430cc6eeb3422b602745
> > Reviewed-on: https://chromium-review.googlesource.com/1039425
> > Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> > Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#555342}
> 
> TBR=phoglund@chromium.org,chfremer@chromium.org
> 
> Change-Id: I9c976f8bb2e0812029d13ae020896bebadf4ef1c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  chromium:831514 , chromium:828568
> Reviewed-on: https://chromium-review.googlesource.com/1041945
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555996}

TBR=phoglund@chromium.org,chfremer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:831514 , chromium:828568
Change-Id: I253b9c60032543f55533b8f53442dcabbebffbf6
Reviewed-on: https://chromium-review.googlesource.com/1054669
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557824}
[modify] https://crrev.com/191d55580e6b2dda1206b51de589e18e7865b863/media/capture/video/video_capture_device_unittest.cc

Comment 14 by dalecur...@chromium.org, Aug 3

Status: Fixed (was: Assigned)
Seems fixed?
►

Sign in to add a comment