droger@ can you have a look?

I have a test disable CL for this landing now: https://chromium-review.googlesource.com/c/chromium/src/+/1008829

 Issue 831848  has been merged into this issue.

Stack:

BrowserTestBase received signal: Terminated. Backtrace:
    #0 0x0000025af481 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
    #1 0x000011f96aaf in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
    #2 0x000013c5e6f2 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:86:5
    #3 0x0000025d6c79 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
    #4 0x7f5f23ecfcb0 in killpg ??:?
    #5 0x7f5f23ecfcb0 in ?? ??:0
    #6 0x7f5f23f89c9d in __poll /build/eglibc-ripdx6/eglibc-2.19/io/../sysdeps/unix/syscall-template.S:81:0
    #7 0x0000025ae0d7 in __interceptor_poll /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3802:13
    #8 0x7f5f2c2666bc in g_main_context_poll /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:4028:11
    #9 0x7f5f2c2666bc in g_main_context_iterate /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3729:0
    #10 0x7f5f2c266bfe in g_main_context_iteration /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3795:12
    #11 0x0000120574d4 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_glib.cc:305:30
    #12 0x000012129740 in base::RunLoop::Run() ./../../base/run_loop.cc:130:14
    #13 0x0000064f1a9e in extensions::(anonymous namespace)::AsyncFunctionRunner::RunMessageLoopUntilResponse() ./../../chrome/browser/extensions/api/identity/identity_apitest.cc:137:25
    #14 0x000006491b06 in extensions::(anonymous namespace)::AsyncFunctionRunner::WaitForError(UIThreadExtensionFunction*) ./../../chrome/browser/extensions/api/identity/identity_apitest.cc:117:5
    #15 0x0000064b992f in WaitForError ./../../chrome/browser/extensions/api/identity/identity_apitest.cc:155:36
    #16 0x0000064b992f in extensions::LaunchWebAuthFlowFunctionTest_UserCloseWindow_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/identity/identity_apitest.cc:2120:0
    #17 0x000013c5d967 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:384:5
    #18 0x0000125efd22 in Run ./../../base/callback.h:124:12
    #19 0x0000125efd22 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2050:0
    #20 0x0000125eae30 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1443:18
    #21 0x00000b7113eb in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1042:13
    #22 0x00000cbf00c1 in Run ./../../base/callback.h:124:12
    #23 0x00000cbf00c1 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:45:0
    #24 0x00000b709d28 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:955:25
    #25 0x00000b720667 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner.cc:140:17
    #26 0x00000b6fd336 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:42:32
    #27 0x000011dec6f9 in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner.cc:427:14
    #28 0x000011def129 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner.cc:706:12
    #29 0x00001ad39b85 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:453:29
    #30 0x000011de8b88 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #31 0x000013c5bcc2 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:321:3
    #32 0x0000123fc595 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:235:20
    #33 0x00000889014c in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
    #34 0x000008894139 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #35 0x000008895b5a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #36 0x0000088ccbe5 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #37 0x0000088cb4d3 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #38 0x00001245c6f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2314:46
    #39 0x00001245c6f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #40 0x000011f5edc2 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
    #41 0x000013d05b36 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
    #42 0x000011f6040e in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
    #43 0x000011f5eb80 in main ./../../chrome/test/base/browser_tests_main.cc:36:10
    #44 0x7f5f23ebaf45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #45 0x00000257302a in _start ??:0:0


Why are we disabling the test instead of reverting https://chromium-review.googlesource.com/995893 ?

It's not clear to me that my CL is causing this, it does not seem related at first glance. Investigating.

I'm pretty convinced that this CL is not the cause (it's only a change in unit tests, and this failure happens in browser tests).

I cannot repro the failure locally with a normal Debug or Release build on linux (I did not try MSAN yet).

We should probably proceed with the disabling for now. For some reason the CL to disable the test did not land.

I submitted the CL disabling the test, the bot hopefully should turn green now.

Flaky on ChromiumOS MSan too:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/