tip-of-tree clang win builds failing device_unittests |
|||
Issue descriptionE.g. https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1329 https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1274 It's been happening for a while. This is a death test. Maybe it's an official build thing?
,
Apr 11 2018
I see Nico already noticed this :-) https://chromium-review.googlesource.com/c/chromium/src/+/999481#message-55b3bc8fe8857b23f45b8687719c408b1cc66e14
,
Apr 11 2018
Removing the expectations string here: https://chromium-review.googlesource.com/#/c/chromium/src/+/1006582
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93e76e38c34fab55bc9f19ba50ced5cc0b4f919e commit 93e76e38c34fab55bc9f19ba50ced5cc0b4f919e Author: Hans Wennborg <hans@chromium.org> Date: Wed Apr 11 09:20:29 2018 Fix U2fParsingUtils.AppendSelfCrashes in official builds Official builds remove the strings passed to CHECKs, causing the expected string to not show up and breaking this test. Removing the expectation strings to unbreak the test for now. As Nico commented on https://crrev.com/c/999481 perhaps a better fix would be to not use a death test at all. TBR=jdoerrie Bug: 831494 Change-Id: Ic9e2ca4cfe4f5f05d47c00fb4727ea37d6fadcfc Reviewed-on: https://chromium-review.googlesource.com/1006582 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#549837} [modify] https://crrev.com/93e76e38c34fab55bc9f19ba50ced5cc0b4f919e/device/fido/u2f_parsing_utils_unittest.cc
,
Apr 11 2018
,
Apr 11 2018
Thanks for the quick fix, apologies for breaking the build. |
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, Apr 11 2018Status: Started (was: Available)