Regression: Unwanted extra space is seen on 'Extension Option' Overlay.
Reported by
aiman.an...@etouch.net,
Apr 11 2018
|
|||||
Issue descriptionChrome Version: 67.0.3393.4 (Official Build) Revision 1c8c7bb130996ac73fdf93473d13849dbcba5240-refs/branch-heads/3393@{#6} (32/64 Bit) OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS). Test URL: https://chrome.google.com/webstore/detail/puzzle-creator/mbalnpbcmecdckpghgacibglihkgamkl?utm_source=chrome-ntp-icon What steps will reproduce the problem? 1. Launch chrome, navigate to above URL, and download the extension. 2. Right click on extension icon in omnibox and select 'Options' from context menu. 3. Observe Extension Option overlay. Actual Result: Unwanted extra space is seen on 'Extension Option' Overlay. Expected Result: Unwanted space should not be seen on 'Extension Option' Overlay. This is a regression issue, broken in M-67 series, and will soon update other info. Good Build:67.0.3376.1 (Revision: 544069) Bad Build:67.0.3377.0 (Revision: 544610) You are probably looking for a change made after 544559 (known good), but no later than 544560 (first known bad). CHANGEL-OG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/b467300e0999d4263fb1bddea43a205be3347931..d289dbadf718e02a2b13d38e5bb1bfa26a090f9d Suspect: https://chromium.googlesource.com/chromium/src/+/d289dbadf718e02a2b13d38e5bb1bfa26a090f9d dpapad@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is also seen on Canary build #67.0.3394.0 Thank You!
,
Apr 11 2018
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ab9504be60176035af5a2bf3f70d0e67f9c4ee9 commit 0ab9504be60176035af5a2bf3f70d0e67f9c4ee9 Author: dpapad <dpapad@chromium.org> Date: Thu Apr 12 05:48:09 2018 MD Extensions: Listen for all preferredsizechanged events. Previously the code assumed that just listening on the 1st occurrence was enough, but it turns out that later occurrences can happen and need to be handled. Bug: 831489 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic06287ca755a32a86e5bd0429c0695073753cefe Reviewed-on: https://chromium-review.googlesource.com/1008064 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550027} [modify] https://crrev.com/0ab9504be60176035af5a2bf3f70d0e67f9c4ee9/chrome/browser/resources/md_extensions/options_dialog.js
,
Apr 12 2018
,
Apr 12 2018
Issue 831314 has been merged into this issue.
,
Apr 13 2018
Issue 828121 has been merged into this issue.
,
Apr 13 2018
Update : Retested above issue on Windows(7,8,8.1,10), Linux(14.04 LTS)and Mac(10.12.6, 10.13.1, 10.13.5) OS using latest Canary #67.0.3396.0 and issue is fixed. Now, Unwanted extra space is not seen on Options overlay. Kindly review the attached screen-cast. Thank you! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpa...@chromium.org
, Apr 11 2018