Issue metadata
Sign in to add a comment
|
desktop-pwas: Location bar is broken on macviews browser |
||||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Enable chrome://flags/#enable-desktop-pwas 2. Go to http://permission.site (http one, NOT https). 3. Open the three dot menu and create a shortcut. 4. Go to chrome://apps, right click the new shortcut and click "Open in Window" 5. Double click the shortcut What is the expected result? Location bar appears under window frame What happens instead of that? Location bar is behind window frame. See attached screenshot.
,
Apr 29 2018
Yup, duplicate. I forgot I had opened this one.
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8d652b1a25a8496a2d2c2b201d90b2f77564451 commit b8d652b1a25a8496a2d2c2b201d90b2f77564451 Author: Trent Apted <tapted@chromium.org> Date: Mon May 28 06:12:32 2018 Disable flaky BrowserFocusTest.PopupLocationBar TBR=ortuno@chromium.org Bug: 846848 , 769327 , 831483 Change-Id: Iaebe8329099b47a369322541eabb50b8307eca41 Reviewed-on: https://chromium-review.googlesource.com/1074891 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#562192} [modify] https://crrev.com/b8d652b1a25a8496a2d2c2b201d90b2f77564451/chrome/browser/ui/browser_focus_uitest.cc
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e739e2671933d445245532567494738aa37c5b2 commit 6e739e2671933d445245532567494738aa37c5b2 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Wed May 30 07:34:54 2018 bookmark-apps: Fix focus test for popup and app windows The browser window wasn't active by the time the test tried to focus it. This caused GetFocusedView() in IsViewFocused() to return nullptr and cause a seg fault. Fixes the test by ensuring the browser is brought to the front before trying to focus it. Also replaces ClickOnView with FocusView since ClickOnView could end up clicking the window in the back if the popup wasn't opened yet. Bug: 846848 , 831483 Change-Id: I66b75dc264b6a82896d5ef20b1a44bc937d367e1 Reviewed-on: https://chromium-review.googlesource.com/1077109 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#562757} [modify] https://crrev.com/6e739e2671933d445245532567494738aa37c5b2/chrome/browser/ui/browser_focus_uitest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Apr 27 2018