New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831480 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Team Drive folder context menu should have "Manage in Drive" option

Project Member Reported by sashab@chromium.org, Apr 11 2018

Issue description

Team Drive folder context menu should have "Open in Drive" option that takes the user to the location of that folder on the Google Drive website.

Add "Open in Drive"
Above "Share with Others"

To clarify: whether it should be for just "Team Drives" or for "Google Drive" folders as well.
 

Comment 1 by sashab@chromium.org, Apr 11 2018

Labels: -Pri-3 Pri-1

Comment 2 by sashab@chromium.org, Apr 11 2018

Labels: M-68

Comment 3 by sashab@chromium.org, Apr 13 2018

This currently works for files but the implementation will be harder for folders. Attached screenshots of the 4 current use cases:

1. File in Google Drive - 'Manage with Drive' opens the doc in Google Drive, 'Share with Others' opens the sharing dialog.
2. Folder in Google Drive - 'Manage with Drive' is greyed out for now, 'Share with Others' opens the sharing dialog.
3. File in Team Drives - 'Manage with Drive' opens the doc in Google Drive, 'Share with Others' also opens the doc in Google Drive.
4. Folder in Team Drives - 'Manage with Drive' and 'Share with Others' are both greyed out.

Waiting to speak with the Drive API team on the best way to get a link to open a folder in Google Drive using the sync API.

drive-file.png
71.8 KB View Download
drive-folder.png
71.1 KB View Download
team-drives-file.png
50.1 KB View Download
team-drives-folder.png
48.7 KB View Download

Comment 4 by sashab@chromium.org, Apr 13 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4cf405644468e744ecf0e630988803df31d6431

commit c4cf405644468e744ecf0e630988803df31d6431
Author: Sasha Morrissey <sashab@chromium.org>
Date: Mon May 07 04:37:40 2018

Add 'Manage in Drive' button to Files App context menu

Adds a 'Manage in Drive' button to the context menu for entries in the
Files app for ChromeOS.

Creates a new DriveManageAction which appears enabled only for
non-directory entries (for now) in Drive when offline mode is not
enabled. Uses getEntryProperties() for the entry to get its
'alternateUrl' (provided by the Drive Sync API) and navigates to this
URL in the browser.

'Manage in Drive', ensure the browser window opens and navigates to the
file.

Test: Right-click on a file in Google Drive in the File Manager, select
Bug:  831480 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieaa359b9e825bef166ea25ec23ae1693681d91f7
Reviewed-on: https://chromium-review.googlesource.com/1011465
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556375}
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/ui/file_manager/file_manager/foreground/js/actions_model.js
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/ui/file_manager/file_manager/foreground/js/actions_model_unittest.js
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/ui/file_manager/file_manager/foreground/js/ui/actions_submenu.js
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/ui/file_manager/file_manager/foreground/js/ui/actions_submenu_unittest.html
[modify] https://crrev.com/c4cf405644468e744ecf0e630988803df31d6431/ui/file_manager/file_manager/main.html

Comment 6 by sashab@chromium.org, May 10 2018

Summary: Team Drive folder context menu should have "Manage in Drive" option (was: Team Drive folder context menu should have "Open in Drive" option)

Comment 7 by sashab@chromium.org, May 17 2018

The Manage in Drive button (clarified with weifangsun@):

* Is shown for all files and folders in My Drive and Team Drives
* Is disabled when in offline mode
* Opens the file in drive.google.com *without* the Sharing dialog open
Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfc3286b56d66b31bb0db85e904d69dd45f11960

commit cfc3286b56d66b31bb0db85e904d69dd45f11960
Author: Sasha Morrissey <sashab@chromium.org>
Date: Thu May 17 06:53:54 2018

Fix incorrect check in 'Manage with Drive' action, and add test

Fix check in 'Manage with Drive' action, and add test to ensure it
doesn't regress again. Also added getLastVisitedUrl() in util.js to get
the URL opened by the Manage in Drive button.

Bug:  831480 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I382a662607103d60a5c9a7c58643eff0f9f62106
Reviewed-on: https://chromium-review.googlesource.com/1058884
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559441}
[modify] https://crrev.com/cfc3286b56d66b31bb0db85e904d69dd45f11960/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/cfc3286b56d66b31bb0db85e904d69dd45f11960/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/cfc3286b56d66b31bb0db85e904d69dd45f11960/ui/file_manager/file_manager/background/js/test_util.js
[modify] https://crrev.com/cfc3286b56d66b31bb0db85e904d69dd45f11960/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/cfc3286b56d66b31bb0db85e904d69dd45f11960/ui/file_manager/file_manager/foreground/js/actions_model.js
[add] https://crrev.com/cfc3286b56d66b31bb0db85e904d69dd45f11960/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js
[delete] https://crrev.com/e695d4ed1baac46152bef7a57baeb03dc98785d6/ui/file_manager/integration_tests/file_manager/share_dialog.js
[modify] https://crrev.com/cfc3286b56d66b31bb0db85e904d69dd45f11960/ui/file_manager/integration_tests/file_manager_test_manifest.json

Project Member

Comment 9 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ae517a3826203e62f79ed30e5593f51eb160664

commit 7ae517a3826203e62f79ed30e5593f51eb160664
Author: Sasha Morrissey <sashab@chromium.org>
Date: Fri May 18 04:14:22 2018

Move |alternate_url| to ResourceEntry in drive.proto

Move |alternate_url| to ResourceEntry in drive.proto. Previously, it was
in FileSpecificInfo, so this patch upgrades it to be set for directories
also.

This is pre-work to allow the 'Manage in Drive' button to work for
folders in the Files app, as well as files.

Bug:  831480 
Change-Id: I07998e09c6de222dfb129894414340cad11cddaa
Reviewed-on: https://chromium-review.googlesource.com/1056779
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559797}
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/components/drive/chromeos/file_system/download_operation.cc
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/components/drive/drive.proto
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/components/drive/file_system/download_operation_unittest.cc
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/components/drive/resource_entry_conversion.cc
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/components/drive/resource_entry_conversion_unittest.cc
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/components/drive/resource_metadata_storage.cc
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/components/drive/resource_metadata_storage.h
[modify] https://crrev.com/7ae517a3826203e62f79ed30e5593f51eb160664/components/drive/resource_metadata_storage_unittest.cc

Comment 10 Deleted

Comment 11 Deleted

Comment 12 Deleted

Project Member

Comment 13 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c21b7d6f9b3b4ec2f42822d9884e3adff5baf93

commit 8c21b7d6f9b3b4ec2f42822d9884e3adff5baf93
Author: Sasha Morrissey <sashab@chromium.org>
Date: Fri May 18 05:15:02 2018

Enable 'Manage in Drive' button for directories in the Files app

Enable the 'Manage in Drive' button for directories, as well as files,
and update the relevant tests. It was previously disabled because
|alternate_url| was not available for directories.

Bug:  831480 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idbd6145608ccaa369ceda01b3cf3996603b4114f
Reviewed-on: https://chromium-review.googlesource.com/1056757
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559805}
[modify] https://crrev.com/8c21b7d6f9b3b4ec2f42822d9884e3adff5baf93/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/8c21b7d6f9b3b4ec2f42822d9884e3adff5baf93/ui/file_manager/file_manager/foreground/js/actions_model.js
[modify] https://crrev.com/8c21b7d6f9b3b4ec2f42822d9884e3adff5baf93/ui/file_manager/file_manager/foreground/js/actions_model_unittest.js
[modify] https://crrev.com/8c21b7d6f9b3b4ec2f42822d9884e3adff5baf93/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js

Status: Fixed (was: Started)

Sign in to add a comment