New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831477 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: ----



Sign in to add a comment

unit_tests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 11 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of peria@chromium.org

unit_tests failing on multiple builders

Builders failed on: 
- linux-chromeos-dbg: 
  https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-dbg
- Linux Tests (dbg)(1)(32): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29
- Linux Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29
- Linux Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests
- Mac10.10 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests
- Mac10.11 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests
- Mac10.13 Tests (dbg): 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.13%20Tests%20%28dbg%29
- Linux ASan LSan Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29
- Linux MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests
- Linux TSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests
- Mac ASan 64 Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29
- Win7 Tests (1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29


Linux tests outputs their stack. Here is an example;

[ RUN      ] TrialComparisonCertVerifierTest.CancelledDuringPrimaryVerification
Received signal 11 SEGV_MAPERR 000000000000
#0 0x0000f2c1d2b7 base::debug::StackTrace::StackTrace()
#1 0x0000f2c1b562 base::debug::StackTrace::StackTrace()
#2 0x0000f2c1ccf9 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x0000f7781420 ([vdso]+0xffffe41f)
#4 0x0000e8a0937a network::SocketFactory::SocketFactory()
#5 0x0000e89c8051 network::NetworkContext::NetworkContext()
#6 0x00000cfa4762 safe_browsing::SafeBrowsingNetworkContext::SharedURLLoaderFactory::InternalState::InitOnIO()
#7 0x00000cfa4e47 _ZN4base8internal13FunctorTraitsIMN13safe_browsing26SafeBrowsingNetworkContext22SharedURLLoaderFactory13InternalStateEFv13scoped_refptrIN3net23URLRequestContextGetterEEN4mojo16InterfaceRequestIN7network5mojom14NetworkContextEEEEvE6InvokeIS6_IS5_EJS9_SF_EEEvSH_OT_DpOT0_
#8 0x00000cfa4d46 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN13safe_browsing26SafeBrowsingNetworkContext22SharedURLLoaderFactory13InternalStateEFv13scoped_refptrIN3net23URLRequestContextGetterEEN4mojo16InterfaceRequestIN7network5mojom14NetworkContextEEEEJS8_IS7_ESB_SH_EEEvOT_DpOT0_
#9 0x00000cfa4c7e _ZN4base8internal7InvokerINS0_9BindStateIMN13safe_browsing26SafeBrowsingNetworkContext22SharedURLLoaderFactory13InternalStateEFv13scoped_refptrIN3net23URLRequestContextGetterEEN4mojo16InterfaceRequestIN7network5mojom14NetworkContextEEEEJS7_IS6_ESA_SG_EEEFvvEE7RunImplISI_NSt3__15tupleIJSJ_SA_SG_EEEJLj0ELj1ELj2EEEEvOT_OT0_NSO_16integer_sequenceIjJXspT1_EEEE
#10 0x00000cfa4ab1 _ZN4base8internal7InvokerINS0_9BindStateIMN13safe_browsing26SafeBrowsingNetworkContext22SharedURLLoaderFactory13InternalStateEFv13scoped_refptrIN3net23URLRequestContextGetterEEN4mojo16InterfaceRequestIN7network5mojom14NetworkContextEEEEJS7_IS6_ESA_SG_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#11 0x0000f2bc8598 _ZNO4base12OnceCallbackIFvvEE3RunEv
#12 0x0000f2c218b7 base::debug::TaskAnnotator::RunTask()
#13 0x0000f2cd0540 base::internal::IncomingTaskQueue::RunTask()
#14 0x0000f2cda51a base::MessageLoop::RunTask()
#15 0x0000f2cda873 base::MessageLoop::DeferOrRunPendingTask()
#16 0x0000f2cdabe0 base::MessageLoop::DoWork()
#17 0x0000f2ce3476 base::MessagePumpLibevent::Run()
#18 0x0000f2cd9bb6 base::MessageLoop::Run()
#19 0x0000f2cd9c07 base::MessageLoop::Run()
#20 0x0000f2da1a3f base::RunLoop::Run()


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3292d8d82fc7638f83d0d694e5b332220857a3d5

commit 3292d8d82fc7638f83d0d694e5b332220857a3d5
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Wed Apr 11 06:00:01 2018

Revert "Add a net::TransportClientSocket class"

This reverts commit 53553a99d99fc81127faf1783dde1d63197da78b.

Reason for revert: This makes unit_tests failed on many bots.

Original change's description:
> Add a net::TransportClientSocket class
> 
> This CL adds a net::TransportClientSocket so that we can have an interface
> to expose socket Bind() method.
> 
> This CL changes the following:
> - socket_test_util.cc
>   Changes MockClientSocket to subclass this new net::TransportClientSocket
>   class instead of net::SSLClientSocket. This new class hierarchy is more
>   intuitive because not all client sockets are ssl socket.
> - client_socket_factory.cc
>   Makes CreateTransportClientSocket() returns a net::TransportClientSocket
>   instead of a StreamSocket.
> - services/network/*
>   Makes network::SocketFactory take in a net::ClientSocketFactory.
> - cast_socket.cc/h and cast_socket_unittest.cc.
> 
> 
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ie258114565e76529555e244364be421e66637960
> Reviewed-on: https://chromium-review.googlesource.com/995554
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549731}

TBR=mmenke@chromium.org,xunjieli@chromium.org,imcheng@chromium.org

Change-Id: If5aea44dc8671f126baf23fab2d4768cc2458fd9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831477 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1006298
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549789}
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/components/cast_channel/cast_socket.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/BUILD.gn
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/dns/address_sorter_posix_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/dns/dns_session_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/client_socket_factory.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/client_socket_factory.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/fuzzed_socket.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/fuzzed_socket.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/fuzzed_socket_factory.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/socket_test_util.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/socket_test_util.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/tcp_client_socket.h
[delete] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/net/socket/transport_client_socket.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/transport_client_socket_pool_test_util.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/net/socket/transport_client_socket_pool_test_util.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/network_context.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/network_context.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/socket_factory.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/socket_factory.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/tcp_connected_socket.h
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/3292d8d82fc7638f83d0d694e5b332220857a3d5/services/network/udp_socket_unittest.cc

Comment 2 by peria@chromium.org, Apr 11 2018

Components: Blink>Network
Labels: -Pri-1 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Owner: xunji...@chromium.org
Status: Fixed (was: Available)
Helen, your CL https://chromium-review.googlesource.com/c/chromium/src/+/995554 looks the trigger.
Could you take a look?

Actual Builds:
- Windows
  https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20(1)/78975
  https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20(1)/36912
  https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/22300
- MacOSX
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31201
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/25300
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/12002
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/1601
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20(dbg)/1238
-Linux
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)(32)/49363
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)/71371
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/69092
- ChromeOS
  https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6797
- Sanitizers
  https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/20108
  https://ci.chromium.org/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20(1)/44655
  https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/9106
  https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/7086
  https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20(1)/39950
  https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/26988

Comment 3 by peria@chromium.org, Apr 11 2018

Status: Assigned (was: Fixed)
Oops, I didn't check bots' status yet.

Comment 4 by peria@chromium.org, Apr 11 2018

Status: Fixed (was: Assigned)
The failures seem gone.

Comment 5 by h...@chromium.org, Apr 11 2018

Cc: h...@chromium.org
 Issue 831528  has been merged into this issue.

Sign in to add a comment