New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831469 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

tablet mode back button is missing

Project Member Reported by warx@chromium.org, Apr 11 2018

Issue description

Please see the attachment

 
Screenshot from 2018-04-10 21-33-55.png
1.4 MB View Download

Comment 1 by warx@chromium.org, Apr 11 2018

Status: Assigned (was: Untriaged)
Repro steps:
- change shelf alignment to left or right
- toggle tablet mode
Cc: newcomer@chromium.org omrilio@chromium.org sammiequon@chromium.org
 Issue 813433  has been merged into this issue.
Labels: Touch-Friendly-Launcher-Urgent
Components: UI>Shell>TouchView
Which versions does this happen on?

Comment 5 by warx@chromium.org, Apr 12 2018

I feel this is not regression. The DUP indicates it also happens on m65.
Yeah, i would guess it came up when i refactored the back button, which is m65.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a893d388a5f001fc83132aa7342552b9660f54

commit b3a893d388a5f001fc83132aa7342552b9660f54
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Apr 12 16:06:11 2018

shelf: Back button shows up when entering tablet with left shelf.

Back button visibility was normally handled on shelf animation finish.
When switching from vertical shelf to tablet mode (force bottom shelf),
there is no animation, so the back button does not show up. This cl
handles that case.

Test: ash_unittests BackButtonTest.*
Bug:  831469 
Change-Id: Ia95e791d30deb5a5c91599039c39094ffa29003b
Reviewed-on: https://chromium-review.googlesource.com/1008163
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550223}
[modify] https://crrev.com/b3a893d388a5f001fc83132aa7342552b9660f54/ash/shelf/back_button_unittest.cc
[modify] https://crrev.com/b3a893d388a5f001fc83132aa7342552b9660f54/ash/shelf/shelf_view.cc
[modify] https://crrev.com/b3a893d388a5f001fc83132aa7342552b9660f54/ash/shelf/shelf_view.h

Labels: Merge-Request-66
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 12 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: josa...@chromium.org
+josafat for permissions
Labels: -Merge-Review-66 Merge-Approved-66
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 13 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fced5ca44d731093920d059dbfc67fc64d97baec

commit fced5ca44d731093920d059dbfc67fc64d97baec
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Apr 13 16:51:16 2018

[merge to m66] shelf: Back button shows up when entering tablet with left shelf.

Back button visibility was normally handled on shelf animation finish.
When switching from vertical shelf to tablet mode (force bottom shelf),
there is no animation, so the back button does not show up. This cl
handles that case.

TBR=sammiequon@google.com

(cherry picked from commit b3a893d388a5f001fc83132aa7342552b9660f54)

Test: ash_unittests BackButtonTest.*
Bug:  831469 
Change-Id: Ia95e791d30deb5a5c91599039c39094ffa29003b
Reviewed-on: https://chromium-review.googlesource.com/1008163
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550223}
Reviewed-on: https://chromium-review.googlesource.com/1012189
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#702}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/fced5ca44d731093920d059dbfc67fc64d97baec/ash/shelf/back_button_unittest.cc
[modify] https://crrev.com/fced5ca44d731093920d059dbfc67fc64d97baec/ash/shelf/shelf_view.cc
[modify] https://crrev.com/fced5ca44d731093920d059dbfc67fc64d97baec/ash/shelf/shelf_view.h

Status: Fixed (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a893d388a5f001fc83132aa7342552b9660f54

commit b3a893d388a5f001fc83132aa7342552b9660f54
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Apr 12 16:06:11 2018

shelf: Back button shows up when entering tablet with left shelf.

Back button visibility was normally handled on shelf animation finish.
When switching from vertical shelf to tablet mode (force bottom shelf),
there is no animation, so the back button does not show up. This cl
handles that case.

Test: ash_unittests BackButtonTest.*
Bug:  831469 
Change-Id: Ia95e791d30deb5a5c91599039c39094ffa29003b
Reviewed-on: https://chromium-review.googlesource.com/1008163
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550223}
[modify] https://crrev.com/b3a893d388a5f001fc83132aa7342552b9660f54/ash/shelf/back_button_unittest.cc
[modify] https://crrev.com/b3a893d388a5f001fc83132aa7342552b9660f54/ash/shelf/shelf_view.cc
[modify] https://crrev.com/b3a893d388a5f001fc83132aa7342552b9660f54/ash/shelf/shelf_view.h

Sign in to add a comment