New issue
Advanced search Search tips

Issue 831463 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: !v8::internal::FLAG_enable_slow_asserts || (object->IsWasmInstanceObject()) in w

Project Member Reported by ClusterFuzz, Apr 11 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6255627408769024

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !v8::internal::FLAG_enable_slow_asserts || (object->IsWasmInstanceObject()) in w
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=52530:52531

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6255627408769024

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 11 2018

Labels: Test-Predator-Auto-Owner
Owner: clemensh@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/fb226a117afb8ffa7b12694d055dbff3190dda84 ([wasm] Avoid transition from unhandlified to handlified).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Labels: Pri-2
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/be1a2316254b38b6e37387e37be29f47f87bcc0d

commit be1a2316254b38b6e37387e37be29f47f87bcc0d
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Apr 11 09:52:19 2018

[wasm][interpreter] Check signature before getting code

On indirect function calls, if the corresponding table entry is empty,
we cannot call {GetCodeFromStartAddress}. In that case, the signature
check will fail anyway, so perform the signature check first, and only
get the code object if the check succeeds.

R=mstarzinger@chromium.org

Bug:  chromium:831463 
Change-Id: Iead949e4c12502b1a2a3949db2dabab4a184a1e7
Reviewed-on: https://chromium-review.googlesource.com/1005005
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52542}
[modify] https://crrev.com/be1a2316254b38b6e37387e37be29f47f87bcc0d/src/wasm/wasm-interpreter.cc
[add] https://crrev.com/be1a2316254b38b6e37387e37be29f47f87bcc0d/test/mjsunit/regress/wasm/regress-831463.js

Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 11 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 6 by ClusterFuzz, Apr 12 2018

ClusterFuzz has detected this issue as fixed in range 52541:52542.

Detailed report: https://clusterfuzz.com/testcase?key=6255627408769024

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !v8::internal::FLAG_enable_slow_asserts || (object->IsWasmInstanceObject()) in w
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=52530:52531
Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=52541:52542

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6255627408769024

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Apr 12 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6255627408769024 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 18

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 28

Labels: -Pri-2 Pri-1

Sign in to add a comment