New issue
Advanced search Search tips

Issue 831429 link

Starred by 1 user
Status: Fixed
Owner:
steimel@chromium.org
Closed: Apr 2018
Cc:
beccahughes@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Modern Media Controls: Hide overlay play button when video is too narrow

Project Member Reported by steimel@chromium.org, Apr 11 2018 
In the legacy controls, we had logic to hide the overlay play button when clipped. We don't hit that codepath in the new controls, but the overlay play button is clipped when the video is under 72px wide
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eb5a3f54237e95b8f2782138ae5b9625dc28640

commit 1eb5a3f54237e95b8f2782138ae5b9625dc28640
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed Apr 11 17:53:57 2018

Hide overlay play button when video is too narrow

This CL adds a check in UpdateOverflowMenuWanted to only show the
overlay play button when the video is wide enough to avoid clipping the
button.

Bug:  831429 
Change-Id: I484d3623f7c49448e57835f70e27678e858f7518
Reviewed-on: https://chromium-review.googlesource.com/1006399
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549926}
[modify] https://crrev.com/1eb5a3f54237e95b8f2782138ae5b9625dc28640/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc

Comment 2 by steimel@chromium.org, Apr 11 2018

Status: Fixed (was: Started)

Comment 3 by sindhu.chelamcherla@chromium.org, Apr 13 2018

Labels: Needs-Feedback
@steimel: Could you please provide sample URL to verify this issue on latest canary from TE end.

Thanks!
►

Sign in to add a comment