New issue
Advanced search Search tips

Issue 831416 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task

Blocked on:
issue 817903
issue 869214


Participants' hotlists:
media-router-fixit


Sign in to add a comment

[Media Router] Eliminate duplicate enums from media_router.mojom

Project Member Reported by mfo...@chromium.org, Apr 10 2018

Issue description

The following enums duplicate declarations in presentation.mojom.

  enum PresentationConnectionState {
    CONNECTING,
    CONNECTED,
    CLOSED,
    TERMINATED
  };

  enum PresentationConnectionCloseReason {
    CONNECTION_ERROR,
    CLOSED,
    WENT_AWAY
  };

Since we are moving to use the Blink types as the canonical definitions for these, we should remove them once presentation.mojom is moved to the Blink public API.  Until that happens, some temporary conversion code will be necessary.


 

Comment 1 by mfo...@chromium.org, Apr 10 2018

Blocking: 817903

Comment 2 by mfo...@chromium.org, Jun 26 2018

Blockedon: 817903
Blocking: -817903
Status: Available (was: Assigned)
When ready, we can start to push Blink types further into the Media Router code and eliminate duplicate MR types.

It might make sense to do this after javascript MRPs are removed to minimize the amount of work.

Status: Assigned (was: Available)
Blockedon: 869214
Cc: mfo...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Cleanups to the Media Router API make sense after native MRPs have fully shipped.

Sign in to add a comment