New issue
Advanced search Search tips

Issue 831412 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add an autotest for tracking rendering power consumption w/ video

Project Member Reported by mcasas@chromium.org, Apr 10 2018

Issue description

In intel, with rapl. Bonus if with combinations: hw/sw decoding,
with/without hw overlays.
 

Comment 1 by pwang@chromium.org, Apr 10 2018

Cc: -ddmail@google.com pwang@chromium.org

Comment 2 by mcasas@chromium.org, Apr 11 2018

Cc: vsu...@chromium.org
pwang@ raised a point that it's worth responding here; there is a
video_PlaybackPerf [1] test but: 

- it doesn't track power consumption if the device is AC powered [2]
 (for the purpose at hand here, we want AC connected).
- The videos played (e.g. [3]) are short and accessed back via a 
 file:/// url (whereas here we want system consumption, hence using
 an http(s):// url -- crosvideo, concretely).
- It doesn't track system features such as hw overlays on/off.
- It's oriented towards measuring dropped frames and CPU consumption.

In short, it's similar but different, so I think a new autotest is
justified.


[1] https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/video_PlaybackPerf/video_PlaybackPerf.py
[2] https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/video_PlaybackPerf/video_PlaybackPerf.py?l=231
[3] https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/video_PlaybackPerf/control.h264?l=27

Comment 3 by ihf@chromium.org, Apr 11 2018

Cc: johnylin@chromium.org kcwu@chromium.org hiroh@chromium.org posciak@chromium.org
+some video folks

My understanding here is that we are interested not in measuring how power efficiently video is decoded, but how efficiently it is displayed, especially with complex UI elements.

Maybe we need special video streams that are really easy on decode?

Comment 4 by mcasas@chromium.org, Apr 13 2018

Summary: Add an autotest for tracking rendering power consumption w/ video (was: Add an autotest for tracking video playback (system) power consumption)
#3: your understanding is correct.

Also I found video_PowerConsumption [1] as a server/site_tests, so
it relies on external infra for meas (prob the USB-C power dongle),
the current test is focused on collecting the RAPL measurements
which have proven to be more accurate and stable and provide better
basis for reasoning and regression monitoring.

[1] https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/server/site_tests/video_PowerConsumption/?dr
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2f13a5c4c222903726af5026c3818d76ce16a706

commit 2f13a5c4c222903726af5026c3818d76ce16a706
Author: Miguel Casas <mcasas@chromium.org>
Date: Sat Apr 14 16:43:59 2018

autotest: Add graphics_VideoRenderingPower autotest

This CL adds a new autotest graphics_VideoRenderingPower,
together with an example vp9 control file; this new test
measures the average power consumption while rendering video
for a while with some different flags (hw overlay on/off).

The result is produced as an output_perf_value with the
idea of adding it to a performance dashboard (see next CL
in the chain).

Bug: chromium:831412 
Change-Id: I30cfc465b474329754a948db1e833ad4c78ce17d
Reviewed-on: https://chromium-review.googlesource.com/1005082
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[add] https://crrev.com/2f13a5c4c222903726af5026c3818d76ce16a706/client/site_tests/graphics_VideoRenderingPower/graphics_VideoRenderingPower.py
[add] https://crrev.com/2f13a5c4c222903726af5026c3818d76ce16a706/client/site_tests/graphics_VideoRenderingPower/control.vp9

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/949c01dee3ccb429bf22644966399d96623c9097

commit 949c01dee3ccb429bf22644966399d96623c9097
Author: Miguel Casas <mcasas@chromium.org>
Date: Sat Apr 14 16:44:08 2018

autotest: Add graphics_VideoRenderingPower to perf_dashboard_config.json

Add graphics_VideoRenderingPower to perf_dashboard_config.json

CQ-DEPEND=CL:1005082
Bug: chromium:831412 
Change-Id: I8dd9dda05b6c8c49dfb324e51c19e33b110184b4
Reviewed-on: https://chromium-review.googlesource.com/1005083
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>

[modify] https://crrev.com/949c01dee3ccb429bf22644966399d96623c9097/tko/perf_upload/perf_dashboard_config.json

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a684b0218c6b7a65773639ee7ad78a3f806238dc

commit a684b0218c6b7a65773639ee7ad78a3f806238dc
Author: Miguel Casas <mcasas@chromium.org>
Date: Wed Apr 18 22:59:01 2018

autotest: wait for idle cpu in graphics_VideoRenderingPower

This CL follows up on a comment/suggestion by ihf@ when landing the
test in the title, to wait for the CPU to calm down before starting
the test steps proper.

[1] https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1005082/9#message-c1655c3ce7ed9928765f8a6c365083b4de2e1622

Change-Id: I04c927dbf9282cb427e90a0155d6a01b5efb5f49
Bug:  chromium:831412 
Reviewed-on: https://chromium-review.googlesource.com/1017060
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Po-Hsien Wang <pwang@chromium.org>
Trybot-Ready: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>

[modify] https://crrev.com/a684b0218c6b7a65773639ee7ad78a3f806238dc/client/site_tests/graphics_VideoRenderingPower/graphics_VideoRenderingPower.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/61cbd3b939ae0fa878f6da91bf1c5ed4191c212e

commit 61cbd3b939ae0fa878f6da91bf1c5ed4191c212e
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 19 10:37:15 2018

autotest-chrome: add graphics_VideoRenderingPower

This CL adds graphics_VideoRenderingPower to the list of tests
to run with/against a Chrome image (with telemetry).

Note that graphics_* tests go in one of two packages: autotest_chrome
and autotest_tests_graphics, the former need a chrome/telemetry
versus the latter that are more stand alone binaries and such.

CQ-DEPEND=CL:1005082, CL:1005083
Bug:  chromium:831412 
Change-Id: If6f93f8038fa85dde0b5c8ff42789a5b1408ece8
Reviewed-on: https://chromium-review.googlesource.com/1010531
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Pohsien Wang <pwang@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/61cbd3b939ae0fa878f6da91bf1c5ed4191c212e/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Status: Fixed (was: Started)
This is landed and working -- notwithstanding potential improvements.
Marking as Fixed.

Sign in to add a comment