Reposition/Resize - Omnibox Keyboard draws controls in wrong location after reposition |
|||
Issue descriptionChrome Version: 67.0.3393.1 Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Navigate to a page, https://www.google.com (2) Enter VR Browsing (3) Reposition the content pane (4) Click the Omnibox URL to bring up the Omnibox Keyboard/Results What is the expected result? The Content should be dismissed and the Omnibox Keyboard/Results controls should be drawn in the current location. What happens instead? Before the Content is dismissed parts of the Omnibox Results are drawn in the original location and then redrawn. See Video for complete scenario. Image shows a single frame where the Omnibox Controls are on screen in the wrong location along with the Content Pane.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2edac0c4ae9d10503663873a746f105a41262a2d commit 2edac0c4ae9d10503663873a746f105a41262a2d Author: Ian Vollick <vollick@chromium.org> Date: Wed Apr 11 14:01:25 2018 [vr] Repositioner and Resizer should update world space transform These previously thought they were clean when they weren't causing stale positions to be applied after repositioning. Bug: 831410 , 831402 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib7b5e1a8023f2231ff68452a43bbb372426b9f2f Reviewed-on: https://chromium-review.googlesource.com/1006355 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549877} [modify] https://crrev.com/2edac0c4ae9d10503663873a746f105a41262a2d/chrome/browser/vr/elements/repositioner.cc [modify] https://crrev.com/2edac0c4ae9d10503663873a746f105a41262a2d/chrome/browser/vr/elements/repositioner.h [modify] https://crrev.com/2edac0c4ae9d10503663873a746f105a41262a2d/chrome/browser/vr/elements/resizer.cc [modify] https://crrev.com/2edac0c4ae9d10503663873a746f105a41262a2d/chrome/browser/vr/elements/resizer.h
,
Apr 13 2018
,
Apr 16 2018
Verified on build 67.0.3396.3 Canary build. Looks good. This appears to have fixed other Reposition/Resize issues. |
|||
►
Sign in to add a comment |
|||
Comment 1 by cjgrant@chromium.org
, Apr 11 2018Status: Assigned (was: Untriaged)