New issue
Advanced search Search tips

Issue 831407 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Accessibility tree doesn't reflect re-ordering of apps in shelf or tabs: view_model bug

Project Member Reported by leberly@chromium.org, Apr 10 2018

Issue description

Google Chrome 67.0.3383.0 (Official Build) dev (64-bit)
Google_Lulu.6301.136.57
Chrome OS with flag enabled: #enable-experimental-accessibility-features

# Enable STS
# Invoke the feature using search key + drag the mouse around the shelf (aka taskbar)
# Note the order the apps are read
# Move the app ordering around, for example, move the Chrome icon to the second to last item in the list
Expected: STS still reads from left to right
Actual: STS retains the original ordering, reading Launcher, then Chrome, then back to Gmail 
 
Related to STS not reading all items in shelf/taskbar 831405

Comment 2 by katie@chromium.org, Apr 10 2018

Cc: dtseng@chromium.org leberly@chromium.org
STS should be using ordering from the Automation tree, so it should match switch access and chromevox.

I tried this with Switch Access as well and saw that the order is also switched there. So the underlying a11y tree is not being updated when items on the shelf are re-ordered.

Comment 3 by katie@chromium.org, Apr 10 2018

Components: UI>Accessibility
Summary: Accessibility tree doesn't reflect re-ordering of apps in shelf (was: STS not respecting order of apps in shelf)

Comment 4 by dtseng@chromium.org, Apr 11 2018

Owner: katie@chromium.org
Status: assigned (was: Available)
The backing view is likely not sending an event (and thus updated tree data), when you reorder using the mouse. Katie, want to take this one on? I can help you find the offending native view if you need.
Labels: -Pri-3 Pri-2
Google Chrome	67.0.3383.0 (Official Build) dev (64-bit)
Firmware Version	Google_Samus.6300.276.0
Chrome OS with flag enabled: #enable-experimental-accessibility-features

This is also affecting apps that have been closed previously but STS and ChromeVox still treat them as there. 
 

Video 1
STS will read closed programs all together with the last program in the shelf. See that I close calculator and text and the last program is called "Calculator Settings Text". After I close the last program, Settings, it goes back to reading the icons as expected.  
https://drive.google.com/file/d/1anKKVjBOvYw4cTi4XVL_yVXXMi6uV2Nf/view

Video 2
STS with the same bug behavior only the last icons in the shelf are all clo
sed. STS shows a highlight where Text and Calculator used to be
https://drive.google.com/file/d/10ZZyzcJlc_OJAFnMxKbajg153qZ6qoRp/view

ChromeVox does the same. 

Comment 6 by katie@chromium.org, Apr 12 2018

Components: -UI>Accessibility>SelectToSpeak
Status: Started (was: Assigned)
Summary: Accessibility tree doesn't reflect re-ordering of apps in shelf or tabs: view_model bug (was: Accessibility tree doesn't reflect re-ordering of apps in shelf)
Digging deeper, this seems to be related to using view_model::Move. The same thing happens when tabs are re-ordered, and they also use view_model.

Comment 7 by katie@chromium.org, Apr 16 2018

Cc: dmazz...@chromium.org
Owner: ----
Status: Available (was: Started)
Tried a fix in https://chromium-review.googlesource.com/c/chromium/src/+/1011592 but after discussion with dmazzoni it might not be the right direction. May want to instead have the a11y tree be able to sort by x,y order of children or similar.

Setting back to 'available'.

Comment 8 by dtseng@chromium.org, Apr 16 2018

As a datapoint, other platforms do this in the opposite way:
- by default, they sort left-to-right, top-to-bottom
- given an explicit attribute set on a container, accessibility will use the tree ordering *for* that container's children.
Labels: SwitchAccessCrOS

Sign in to add a comment