Reposition/Resize - 2D UI Keyboard remains in original location |
||||
Issue descriptionChrome Version: 67.0.3393.1 Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Navigate to https://www.google.com (2) Enter VR Browsing (3) Use Reposition to move the content to a no location. (4) Click the Google Search edit box on the page, this should bring up the 2D UI Keyboard. What is the expected result? The Keyboard should be positioned relative to the content pane, directly below it. What happens instead? The 2D UI Keyboard was placed relative to the original position. This is a regression from previous behavior.
,
Apr 11 2018
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2edac0c4ae9d10503663873a746f105a41262a2d commit 2edac0c4ae9d10503663873a746f105a41262a2d Author: Ian Vollick <vollick@chromium.org> Date: Wed Apr 11 14:01:25 2018 [vr] Repositioner and Resizer should update world space transform These previously thought they were clean when they weren't causing stale positions to be applied after repositioning. Bug: 831410 , 831402 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib7b5e1a8023f2231ff68452a43bbb372426b9f2f Reviewed-on: https://chromium-review.googlesource.com/1006355 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549877} [modify] https://crrev.com/2edac0c4ae9d10503663873a746f105a41262a2d/chrome/browser/vr/elements/repositioner.cc [modify] https://crrev.com/2edac0c4ae9d10503663873a746f105a41262a2d/chrome/browser/vr/elements/repositioner.h [modify] https://crrev.com/2edac0c4ae9d10503663873a746f105a41262a2d/chrome/browser/vr/elements/resizer.cc [modify] https://crrev.com/2edac0c4ae9d10503663873a746f105a41262a2d/chrome/browser/vr/elements/resizer.h
,
Apr 13 2018
,
May 8 2018
Fix verified in build 67.0.3396.29 beta. Looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by cjgrant@chromium.org
, Apr 10 2018Status: Assigned (was: Untriaged)