New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831394 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Safe Browsing] Report size of archives inside of downloaded zips

Project Member Reported by nparker@chromium.org, Apr 10 2018

Issue description

When we find files of type ClientDownloadRequest::ZIPPED_ARCHIVE inside a zip, we're not reporting that file's size or digest.  We should.
 
Issue 845239 has been merged into this issue.

Comment 2 by auk@google.com, May 22 2018

Note: both digest and size are missing for the zip inside the zip.
Cc: vakh@chromium.org
Owner: drubery@chromium.org

Comment 4 by vakh@chromium.org, Jun 25 2018

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8731e71da540844e31bce3f8fca36f838e6883b2

commit 8731e71da540844e31bce3f8fca36f838e6883b2
Author: Daniel Rubery <drubery@chromium.org>
Date: Wed Jun 27 17:09:49 2018

Populate length and digest for ZIP files contained in ZIPs

Also removed arraysize in this file, since it has been
deprecated in favor of base::size().

Bug:  831394 
Change-Id: I8b279a188d786f3ef234565de8e4647970b0f0ae
Reviewed-on: https://chromium-review.googlesource.com/1114223
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570821}
[modify] https://crrev.com/8731e71da540844e31bce3f8fca36f838e6883b2/chrome/common/safe_browsing/zip_analyzer.cc
[modify] https://crrev.com/8731e71da540844e31bce3f8fca36f838e6883b2/chrome/services/file_util/public/cpp/sandboxed_zip_analyzer_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment