New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 831383 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 820528



Sign in to add a comment

Hide the title bar on ARC but keep it for overview mode

Project Member Reported by osh...@chromium.org, Apr 10 2018

Issue description

Chrome side caption currently shows the title set by client,
and which should be empty (UX decision).

However, this information is used by overview mode, so we can't simply
skip this from client (wayland service on Android) side.

Client_controlled_shell_surface should set the
the title on aura window directly, instead of updating via widget, i think.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a594226807407dbbff625b9207bccf31c84cc28d

commit a594226807407dbbff625b9207bccf31c84cc28d
Author: David Reveman <reveman@chromium.org>
Date: Mon Apr 16 16:20:38 2018

vm_tools: Remove show window title option from sommelier.

We want to be able to show the window title in overview mode. In
order to support this, we need to always set the title and instead
have chrome hide it while not in overview mode.

TBR=smbarber@chromium.org
BUG= chromium:831383 
TEST='sommelier -X xterm' shows window title in overview mode

Change-Id: I670bb7a1726533c4a56adeb82e4f2d7f111f3e99
Reviewed-on: https://chromium-review.googlesource.com/1013245
Commit-Ready: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>

[modify] https://crrev.com/a594226807407dbbff625b9207bccf31c84cc28d/vm_tools/sommelier/sommelier.c

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4f22c7abbb0a2df8c56394511e549e12520f06a

commit e4f22c7abbb0a2df8c56394511e549e12520f06a
Author: Jun Mukai <mukai@google.com>
Date: Wed Apr 18 00:00:55 2018

Hide the title in the title bar for ARC apps

As is said in the bug, we decided not to show the title in the
title bar for ARC apps. However, debugging information (stored
in extra_title_) wants to appear, and the overview mode wants
to show the actual title (app name) instead of the debugging
information.

So this CL changed ClientControlledShellSurface as:
- GetWindowTitle always return extra_title_ and no title_ so
  title won't appear anymore
- when the widget's title is updated, directly specify the
  native window's title which is used by the overview mode

Bug:  831383 
Test: manually, exo_unittests
Change-Id: Ifa275bd6f5c72b8ca36cccf7f9c629498c4a670e
Reviewed-on: https://chromium-review.googlesource.com/1012783
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551529}
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/ash/frame/custom_frame_view_ash.h
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/ash/frame/default_frame_header.cc
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/ash/frame/default_frame_header.h
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/ash/frame/header_view.h
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/components/exo/client_controlled_shell_surface.h
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/components/exo/shell_surface_base.cc
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/components/exo/shell_surface_base.h
[modify] https://crrev.com/e4f22c7abbb0a2df8c56394511e549e12520f06a/components/exo/shell_surface_unittest.cc

Comment 3 by mukai@chromium.org, Apr 18 2018

Status: Fixed (was: Assigned)

Comment 4 by mukai@chromium.org, Apr 18 2018

Labels: Merge-Request-67
Status: Assigned (was: Fixed)
Requesting merge of #2 crrev.com/551529 to M67.
Not a small change; is this mostly cosmetic?    User impact if declined?
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 19 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 820528
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 23 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by mukai@chromium.org, Apr 23 2018

re #5: indeed it touches several files, but most of the changes are tiny, adding some interfaces to pass through, I believe that's safe.  This is a part of issue 820528, and will cause user visible effect (only on ARC++ apps in ChromeOS though). 
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 23 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ea6fb617628215443190177739edd6fcfe1358

commit 02ea6fb617628215443190177739edd6fcfe1358
Author: Jun Mukai <mukai@google.com>
Date: Mon Apr 23 17:58:05 2018

Hide the title in the title bar for ARC apps

As is said in the bug, we decided not to show the title in the
title bar for ARC apps. However, debugging information (stored
in extra_title_) wants to appear, and the overview mode wants
to show the actual title (app name) instead of the debugging
information.

So this CL changed ClientControlledShellSurface as:
- GetWindowTitle always return extra_title_ and no title_ so
  title won't appear anymore
- when the widget's title is updated, directly specify the
  native window's title which is used by the overview mode

TBR=mukai@google.com

(cherry picked from commit e4f22c7abbb0a2df8c56394511e549e12520f06a)

Bug:  831383 
Test: manually, exo_unittests
Change-Id: Ifa275bd6f5c72b8ca36cccf7f9c629498c4a670e
Reviewed-on: https://chromium-review.googlesource.com/1012783
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551529}
Reviewed-on: https://chromium-review.googlesource.com/1024247
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#227}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/ash/frame/custom_frame_view_ash.h
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/ash/frame/default_frame_header.cc
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/ash/frame/default_frame_header.h
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/ash/frame/header_view.h
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/components/exo/client_controlled_shell_surface.h
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/components/exo/shell_surface_base.cc
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/components/exo/shell_surface_base.h
[modify] https://crrev.com/02ea6fb617628215443190177739edd6fcfe1358/components/exo/shell_surface_unittest.cc

Comment 11 by mukai@chromium.org, Apr 23 2018

Status: Fixed (was: Assigned)
Cc: dhadd...@chromium.org
Status: Verified (was: Fixed)
Verified on 10575.32.0, 67.0.3396.41.
Labels: -M-67 M-68
Status: Assigned (was: Verified)
I'm still seeing this issue on M68 (10684.0.0, 68.0.3432.0). Actual title (app name) is shown on Title bar of ARC app, both in normal & tablet mode.

Comment 14 by mukai@chromium.org, May 21 2018

Status: Fixed (was: Assigned)
There was a regression, but the fix was merged recently as http://crrev.com/560373. Marking as fixed.
Status: Verified (was: Fixed)
Verified on M68 (10715.0.0, 68.0.3438.0) caroline device.

Sign in to add a comment